From: Eric Blake <eblake@redhat.com>
To: Olaf Hering <olaf@aepfle.de>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
"open list:X86" <xen-devel@lists.xensource.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH for-2.8 v3] xen_disk: split discard input to match internal representation
Date: Wed, 23 Nov 2016 05:40:00 -0600 [thread overview]
Message-ID: <96433c69-0e6d-7cd9-3adb-6349d7dff1b3@redhat.com> (raw)
In-Reply-To: <20161123103912.26699-1-olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
On 11/23/2016 04:39 AM, Olaf Hering wrote:
> The guest sends discard requests as u64 sector/count pairs, but the
> block layer operates internally with s64/s32 pairs. The conversion
> leads to IO errors in the guest, the discard request is not processed.
>
> domU.cfg:
> 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2'
> domU:
> mkfs.ext4 -F /dev/xvda
> Discarding device blocks: failed - Input/output error
>
> Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS.
> Add input range checking to avoid overflow.
>
> Fixes f313520 ("xen_disk: add discard support")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
Qualifies as a bug fix, so requesting 2.8 inclusion.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-11-23 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 10:39 [Qemu-devel] [PATCH v3] xen_disk: split discard input to match internal representation Olaf Hering
2016-11-23 11:40 ` Eric Blake [this message]
2016-11-23 12:27 ` [Qemu-devel] [PATCH for-2.8 " Kevin Wolf
2016-11-23 18:46 ` Stefano Stabellini
2016-11-23 20:44 ` Olaf Hering
2016-11-23 22:13 ` Olaf Hering
2016-11-23 15:50 ` [Qemu-devel] [PATCH " Anthony PERARD
2016-11-23 18:46 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96433c69-0e6d-7cd9-3adb-6349d7dff1b3@redhat.com \
--to=eblake@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).