From: "Cédric Le Goater" <clg@redhat.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
Eric Auger <eric.auger@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Avihai Horon <avihaih@nvidia.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] vfio/migration: Add x-migration-load-config-after-iter VFIO property
Date: Tue, 15 Jul 2025 11:21:51 +0200 [thread overview]
Message-ID: <964728df-afff-4e7a-b1f1-f920e6a7913f@redhat.com> (raw)
In-Reply-To: <8a541c48-15d9-4609-bad7-a1606eeff22e@maciej.szmigiero.name>
>> Using 'strcmp(target_name(), "aarch64")' is quite unique in the QEMU code
>> base, and to be honest, I’m not too keen on adding it unless there’s really
>> no other option.
>
> The previous versions simply tested the TARGET_ARM macro but commit
> 5731baee6c3c ("hw/vfio: Compile some common objects once") made the
> migration-multifd.c file target-independent so it cannot use target-specific
> macros now.
>
> Another option would be to move vfio_load_config_after_iter() to helpers.c
> since that file is target-dependent and can simply test TARGET_ARM
> macro (#if defined(TARGET_ARM)) instead of doing strcmp(target_name(), "aarch64")
> which I agree looks weird.
This would look better than testing target_name(). Let's do that.
Thanks,
C.
next prev parent reply other threads:[~2025-07-15 9:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 17:51 [PATCH 0/3] VFIO multifd device state transfer patches for QEMU 10.1 Maciej S. Szmigiero
2025-06-24 17:51 ` [PATCH 1/3] vfio/migration: Max in-flight VFIO device state buffer count limit Maciej S. Szmigiero
2025-07-01 18:29 ` Fabiano Rosas
2025-07-07 9:29 ` Avihai Horon
2025-07-07 10:47 ` Maciej S. Szmigiero
2025-07-15 8:57 ` Cédric Le Goater
2025-06-24 17:51 ` [PATCH 2/3] vfio/migration: Add x-migration-load-config-after-iter VFIO property Maciej S. Szmigiero
2025-07-01 18:29 ` Fabiano Rosas
2025-07-02 6:27 ` Cédric Le Goater
2025-07-02 6:31 ` Cédric Le Goater
2025-07-02 17:27 ` Maciej S. Szmigiero
2025-07-15 9:21 ` Cédric Le Goater [this message]
2025-07-08 8:34 ` Avihai Horon
2025-07-15 9:08 ` Cédric Le Goater
2025-07-15 9:21 ` Avihai Horon
2025-06-24 17:51 ` [PATCH 3/3] vfio/migration: Add also max in-flight VFIO device state buffers size limit Maciej S. Szmigiero
2025-07-01 18:29 ` Fabiano Rosas
2025-07-07 9:32 ` Avihai Horon
2025-07-14 9:46 ` [PATCH 0/3] VFIO multifd device state transfer patches for QEMU 10.1 Maciej S. Szmigiero
2025-07-15 9:25 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964728df-afff-4e7a-b1f1-f920e6a7913f@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avihaih@nvidia.com \
--cc=eric.auger@redhat.com \
--cc=farosas@suse.de \
--cc=mail@maciej.szmigiero.name \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).