From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Luc Michel" <luc.michel@amd.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Sai Pavan Boddu" <sai.pavan.boddu@amd.com>,
"Joel Stanley" <joel@jms.id.au>
Cc: Guenter Roeck <linux@roeck-us.net>,
Palmer Dabbelt <palmer@dabbelt.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Strahinja Jankovic <strahinja.p.jankovic@gmail.com>,
qemu-riscv@nongnu.org, qemu-arm@nongnu.org,
Bin Meng <bmeng.cn@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Beniamino Galvani <b.galvani@gmail.com>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Weiwei Li <liwei1518@gmail.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH-for-10.1 00/11] hw/sd: Fix SD cards in SPI mode
Date: Thu, 31 Jul 2025 23:34:30 +0200 [thread overview]
Message-ID: <9652db52-68d2-41f6-8db4-94c31eecf35c@linaro.org> (raw)
In-Reply-To: <20250731212807.2706-1-philmd@linaro.org>
(Cc'ing few more ppl who worked on hw/sd/)
On 31/7/25 23:27, Philippe Mathieu-Daudé wrote:
> This series fix a pair of issues with SD cards used wired
> via a SPI link / controller.
>
> Such mode implementation was minimal. I was testing it with
> the ARM Gumstix machines, but we remove them in the v9.2.0
> release (commit a2ccff4d2bc ), so they bit-rotted.
>
> Although the series looks big, I shrinked it a lot to have
> the minimum amount of meaningful changes. Other changes
> added during debugging will be shared later, as I believe
> they will still be useful to debug other future issues.
>
> The last patch add testing coverage, to avoid further bitrot.
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (11):
> hw/sd/sdcard: Do not ignore errors in sd_cmd_to_sendingdata()
> hw/sd/sdbus: Provide buffer size to sdbus_do_command()
> hw/sd/sdcard: Propagate response size to sd_response_r*_make()
> hw/sd/sdcard: Fill SPI response bits in card code
> hw/sd/sdcard: Implement SPI R2 return value
> hw/sd/sdcard: Use complete SEND_OP_COND implementation in SPI mode
> hw/sd/sdcard: Allow using SWITCH_FUNCTION in more SPI states
> hw/sd/sdcard: Factor spi_cmd_SEND_CxD() out
> hw/sd/sdcard: Disable checking STBY mode in SPI SEND_CSD/CID
> hw/sd/sdcard: Remove SDState::mode field
> tests/functional: Test SD cards in SPI mode (using sifive_u machine)
>
> MAINTAINERS | 1 +
> include/hw/sd/sd.h | 23 ++-
> hw/sd/allwinner-sdhost.c | 5 +-
> hw/sd/bcm2835_sdhost.c | 5 +-
> hw/sd/core.c | 5 +-
> hw/sd/omap_mmc.c | 2 +-
> hw/sd/pl181.c | 4 +-
> hw/sd/sd.c | 202 +++++++++++++++-------
> hw/sd/sdhci.c | 4 +-
> hw/sd/ssi-sd.c | 96 ++--------
> hw/sd/trace-events | 4 +-
> tests/functional/meson.build | 1 +
> tests/functional/test_riscv64_sifive_u.py | 51 ++++++
> 13 files changed, 238 insertions(+), 165 deletions(-)\
Without the 51 lines added by the test, only 22 lines of C are added =)
prev parent reply other threads:[~2025-07-31 21:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 21:27 [PATCH-for-10.1 00/11] hw/sd: Fix SD cards in SPI mode Philippe Mathieu-Daudé
2025-07-31 21:27 ` [PATCH-for-10.1 01/11] hw/sd/sdcard: Do not ignore errors in sd_cmd_to_sendingdata() Philippe Mathieu-Daudé
2025-08-01 6:40 ` Richard Henderson
2025-07-31 21:27 ` [PATCH-for-10.1 02/11] hw/sd/sdbus: Provide buffer size to sdbus_do_command() Philippe Mathieu-Daudé
2025-08-01 7:08 ` Richard Henderson
2025-07-31 21:27 ` [PATCH-for-10.1 03/11] hw/sd/sdcard: Propagate response size to sd_response_r*_make() Philippe Mathieu-Daudé
2025-08-01 7:17 ` Richard Henderson
2025-07-31 21:27 ` [PATCH-for-10.1 04/11] hw/sd/sdcard: Fill SPI response bits in card code Philippe Mathieu-Daudé
2025-08-01 7:19 ` Richard Henderson
2025-08-04 9:11 ` Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 05/11] hw/sd/sdcard: Implement SPI R2 return value Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 06/11] hw/sd/sdcard: Use complete SEND_OP_COND implementation in SPI mode Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 07/11] hw/sd/sdcard: Allow using SWITCH_FUNCTION in more SPI states Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 08/11] hw/sd/sdcard: Factor spi_cmd_SEND_CxD() out Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 09/11] hw/sd/sdcard: Disable checking STBY mode in SPI SEND_CSD/CID Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 10/11] hw/sd/sdcard: Remove SDState::mode field Philippe Mathieu-Daudé
2025-07-31 21:28 ` [PATCH-for-10.1 11/11] tests/functional: Test SD cards in SPI mode (using sifive_u machine) Philippe Mathieu-Daudé
2025-07-31 21:34 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9652db52-68d2-41f6-8db4-94c31eecf35c@linaro.org \
--to=philmd@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=b.galvani@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bmeng.cn@gmail.com \
--cc=clg@kaod.org \
--cc=dbarboza@ventanamicro.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux@roeck-us.net \
--cc=liwei1518@gmail.com \
--cc=luc.michel@amd.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sai.pavan.boddu@amd.com \
--cc=strahinja.p.jankovic@gmail.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).