From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6gF-0004R5-Cq for qemu-devel@nongnu.org; Thu, 22 Sep 2016 12:17:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn6gA-000065-C2 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 12:16:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn6gA-00005y-6N for qemu-devel@nongnu.org; Thu, 22 Sep 2016 12:16:54 -0400 References: <1474548655-157373-1-git-send-email-imammedo@redhat.com> <1474548655-157373-8-git-send-email-imammedo@redhat.com> <20160922180017.1f35fc5a@nial.brq.redhat.com> From: Paolo Bonzini Message-ID: <9664929b-6b84-ae11-0682-3743e7a78238@redhat.com> Date: Thu, 22 Sep 2016 18:16:47 +0200 MIME-Version: 1.0 In-Reply-To: <20160922180017.1f35fc5a@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, rkrcmar@redhat.com, ehabkost@redhat.com, mst@redhat.com, kevin@koconnor.net, lersek@redhat.com, chao.gao@intel.com, peterx@redhat.com, liuxiaojian6@huawei.com On 22/09/2016 18:00, Igor Mammedov wrote: > > Why not just return initial_apic_id? This is the meaning the property > > had before your patch. > > initial_apic_id is immutable but 'id' could be changed at runtime by guest in xAPIC mode > so returned value depends on xAPIC/x2APIC mode Understood, but this is just a possibly poorly-named property. "id" (e.g. from info qtree as opposed to info lapic) used to be the initial APIC ID always, even in x2APIC mode. Not a big deal, but thought I'd mention it since you can keep using static properties. Paolo > so I'm just following spec here.