From: Thomas Huth <thuth@redhat.com>
To: "Michael Tokarev" <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>, qemu-trivial@nongnu.org
Subject: Re: [PATCH 0/3] hw/mips/jazz: Rework the NIC init code
Date: Thu, 7 Sep 2023 13:37:19 +0200 [thread overview]
Message-ID: <96673508-be8a-d26b-a731-fd07580086eb@redhat.com> (raw)
In-Reply-To: <a9aa3e9e-dbde-54ed-1df0-749f483806f6@tls.msk.ru>
On 01/09/2023 12.15, Michael Tokarev wrote:
> 25.08.2023 20:51, Thomas Huth wrote:
>> The NIC init code of the jazz machines is rather cumbersome, with
>> a for-loop around it that is always left after the first iteration.
>> This patch series reworks this a little bit to make the code more
>> readable and shorter.
>>
>> Thomas Huth (3):
>> hw/mips/jazz: Remove the big_endian variable
>> hw/mips/jazz: Move the NIC init code into a separate function
>> hw/mips/jazz: Simplify the NIC setup code
>
> Thomas, after comments for "hw/mips/jazz: Remove the big_endian variable",
> will you respin?
I've now sent a patch to clean up that ugliness with TARGET_BIG_ENDIAN first:
https://lore.kernel.org/qemu-devel/20230907113500.185276-1-thuth@redhat.com/
Once that has been accepted, I'll respin the other patches.
Thomas
prev parent reply other threads:[~2023-09-07 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 17:51 [PATCH 0/3] hw/mips/jazz: Rework the NIC init code Thomas Huth
2023-08-25 17:51 ` [PATCH 1/3] hw/mips/jazz: Remove the big_endian variable Thomas Huth
2023-08-25 21:37 ` Richard Henderson
2023-08-28 12:19 ` Philippe Mathieu-Daudé
2023-08-28 12:41 ` Thomas Huth
2023-08-28 15:48 ` Philippe Mathieu-Daudé
2023-08-28 17:00 ` Thomas Huth
2023-08-29 10:04 ` Peter Maydell
2023-08-25 17:51 ` [PATCH 2/3] hw/mips/jazz: Move the NIC init code into a separate function Thomas Huth
2023-08-25 17:51 ` [PATCH 3/3] hw/mips/jazz: Simplify the NIC setup code Thomas Huth
2023-09-01 10:15 ` [PATCH 0/3] hw/mips/jazz: Rework the NIC init code Michael Tokarev
2023-09-07 11:37 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96673508-be8a-d26b-a731-fd07580086eb@redhat.com \
--to=thuth@redhat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=mjt@tls.msk.ru \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).