From: Laurent Vivier <laurent@vivier.eu>
To: Luke Shumaker <lukeshu@lukeshu.com>, qemu-devel@nongnu.org
Cc: Luke Shumaker <lukeshu@parabola.nu>, Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH 01/10] linux-user: Use #if to only call validate_guest_space for 32-bit ARM target
Date: Fri, 9 Mar 2018 21:20:30 +0100 [thread overview]
Message-ID: <966b35a3-654c-fabf-e416-86b14da9fd29@vivier.eu> (raw)
In-Reply-To: <20171228180814.9749-2-lukeshu@lukeshu.com>
Le 28/12/2017 à 19:08, Luke Shumaker a écrit :
> From: Luke Shumaker <lukeshu@parabola.nu>
>
> Instead of defining a bogus validate_guest_space that always returns 1 on
> targets other than 32-bit ARM, use #if blocks to only call it on 32-bit ARM
> targets. This makes the "normal" flow control clearer.
>
> Signed-off-by: Luke Shumaker <lukeshu@parabola.nu>
> ---
> linux-user/elfload.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
With the change request by Peter (condition "!= 1"),
applied to my 'linux-user-for-2.12' branch.
Thanks,
Laurent
next prev parent reply other threads:[~2018-03-09 20:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 18:08 [Qemu-devel] [PATCH 00/10] linux-user: Speed up guest space initialization on 32-bit ARM target Luke Shumaker
2017-12-28 18:08 ` [Qemu-devel] [PATCH 01/10] linux-user: Use #if to only call validate_guest_space for " Luke Shumaker
2018-02-23 18:35 ` Peter Maydell
2018-02-23 18:48 ` Peter Maydell
2018-03-02 13:18 ` Peter Maydell
2018-03-09 20:20 ` Laurent Vivier [this message]
2017-12-28 18:08 ` [Qemu-devel] [PATCH 02/10] linux-user: Rename validate_guest_space => init_guest_commpage Luke Shumaker
2018-03-02 13:18 ` Peter Maydell
2018-03-09 20:24 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 03/10] linux-user: init_guest_space: Clean up if we can't initialize the commpage Luke Shumaker
2018-02-23 18:38 ` Peter Maydell
2018-03-09 20:25 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 04/10] linux-user: init_guest_space: Correctly handle guest_start in commpage initialization Luke Shumaker
2018-03-02 13:19 ` Peter Maydell
2018-03-09 20:26 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 05/10] linux-user: init_guest_space: Clarify page alignment logic Luke Shumaker
2018-03-02 13:19 ` Peter Maydell
2018-03-09 20:28 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 06/10] linux-user: init_guest_commpage: Add a comment about size check Luke Shumaker
2018-03-02 13:20 ` Peter Maydell
2018-03-09 20:30 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 07/10] linux-user: init_guest_space: Clean up control flow a bit Luke Shumaker
2018-03-02 13:20 ` Peter Maydell
2018-03-09 20:37 ` Laurent Vivier
2018-03-13 13:30 ` Laurent Vivier
2018-03-13 13:54 ` Peter Maydell
2018-03-13 14:00 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 08/10] linux-user: init_guest_space: Don't try to align if we'll reject it Luke Shumaker
2018-03-02 13:20 ` Peter Maydell
2018-03-13 14:02 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 09/10] linux-user: init_guest_space: Add a comment about search strategy Luke Shumaker
2018-03-02 13:20 ` Peter Maydell
2018-03-13 14:04 ` Laurent Vivier
2017-12-28 18:08 ` [Qemu-devel] [PATCH 10/10] linux-user: init_guest_space: Try to make ARM space+commpage continuous Luke Shumaker
2018-03-02 14:13 ` Peter Maydell
2018-03-03 14:09 ` Richard Henderson
2018-03-20 15:23 ` Laurent Vivier
2018-03-20 15:53 ` Peter Maydell
2018-03-20 18:49 ` Luke Shumaker
2018-03-20 18:50 ` Laurent Vivier
2018-03-20 18:57 ` Peter Maydell
2018-01-15 17:33 ` [Qemu-devel] [PATCH 00/10] linux-user: Speed up guest space initialization on 32-bit ARM target Luke Shumaker
2018-02-09 2:29 ` Luke Shumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=966b35a3-654c-fabf-e416-86b14da9fd29@vivier.eu \
--to=laurent@vivier.eu \
--cc=lukeshu@lukeshu.com \
--cc=lukeshu@parabola.nu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).