* [PATCH] gdbstub: Fix SEGFAULT in find_cpu_clusters()
@ 2023-09-14 12:25 Nikita Shubin
2023-09-14 12:29 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Nikita Shubin @ 2023-09-14 12:25 UTC (permalink / raw)
To: Alex Bennée, Philippe Mathieu-Daudé; +Cc: Nikita Shubin, qemu-devel
From: Nikita Shubin <n.shubin@yadro.com>
target_xml is a dynamic GString, use NULL to initialize it.
Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml")
Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
---
Observed with:
build-qemu/qemu-system-riscv64 -M sifive_u -bios none -nographic -s
Segmentation fault
---
gdbstub/softmmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbstub/softmmu.c b/gdbstub/softmmu.c
index 9f0b8b5497..42645d2220 100644
--- a/gdbstub/softmmu.c
+++ b/gdbstub/softmmu.c
@@ -292,7 +292,7 @@ static int find_cpu_clusters(Object *child, void *opaque)
assert(cluster->cluster_id != UINT32_MAX);
process->pid = cluster->cluster_id + 1;
process->attached = false;
- process->target_xml[0] = '\0';
+ process->target_xml = NULL;
return 0;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gdbstub: Fix SEGFAULT in find_cpu_clusters()
2023-09-14 12:25 [PATCH] gdbstub: Fix SEGFAULT in find_cpu_clusters() Nikita Shubin
@ 2023-09-14 12:29 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-09-14 12:29 UTC (permalink / raw)
To: Nikita Shubin, Alex Bennée; +Cc: Nikita Shubin, qemu-devel
Hi Nikita,
On 14/9/23 14:25, Nikita Shubin wrote:
> From: Nikita Shubin <n.shubin@yadro.com>
>
> target_xml is a dynamic GString, use NULL to initialize it.
>
> Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml")
>
> Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
> ---
> Observed with:
> build-qemu/qemu-system-riscv64 -M sifive_u -bios none -nographic -s
> Segmentation fault
> ---
> gdbstub/softmmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbstub/softmmu.c b/gdbstub/softmmu.c
> index 9f0b8b5497..42645d2220 100644
> --- a/gdbstub/softmmu.c
> +++ b/gdbstub/softmmu.c
> @@ -292,7 +292,7 @@ static int find_cpu_clusters(Object *child, void *opaque)
> assert(cluster->cluster_id != UINT32_MAX);
> process->pid = cluster->cluster_id + 1;
> process->attached = false;
> - process->target_xml[0] = '\0';
> + process->target_xml = NULL;
Yes, good catch. Akihiko also posted the same fix 2 days ago:
https://lore.kernel.org/qemu-devel/20230912065811.27796-2-akihiko.odaki@daynix.com/
>
> return 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-14 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-14 12:25 [PATCH] gdbstub: Fix SEGFAULT in find_cpu_clusters() Nikita Shubin
2023-09-14 12:29 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).