From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, qemu-s390x@nongnu.org,
David Hildenbrand <david@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Farhan Ali <alifm@linux.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] hw/s390/ccw.c: Don't take address of packed members
Date: Thu, 13 Dec 2018 21:06:58 +0100 [thread overview]
Message-ID: <9683dc80-e258-149a-8a55-3d53cd248761@redhat.com> (raw)
In-Reply-To: <20181213120252.21697-1-peter.maydell@linaro.org>
On 2018-12-13 13:02, Peter Maydell wrote:
> Taking the address of a field in a packed struct is a bad idea, because
> it might not be actually aligned enough for that pointer type (and
> thus cause a crash on dereference on some host architectures). Newer
> versions of clang warn about this.
>
> Avoid the problem by using local copies of the PMCW and SCSW
> struct fields in copy_schib_from_guest() and copy_schib_to_guest().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2 changes:
> * add comment about why we're using locals
Thanks!
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2018-12-13 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 12:02 [Qemu-devel] [PATCH v2] hw/s390/ccw.c: Don't take address of packed members Peter Maydell
2018-12-13 13:00 ` Farhan Ali
2018-12-13 14:56 ` Cornelia Huck
2018-12-13 20:06 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9683dc80-e258-149a-8a55-3d53cd248761@redhat.com \
--to=thuth@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).