From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38629)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fromani@redhat.com>) id 1XwSGy-0000xw-5B
	for qemu-devel@nongnu.org; Thu, 04 Dec 2014 04:00:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fromani@redhat.com>) id 1XwSGs-0006Wi-7O
	for qemu-devel@nongnu.org; Thu, 04 Dec 2014 04:00:28 -0500
Received: from mx6-phx2.redhat.com ([209.132.183.39]:47817)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fromani@redhat.com>) id 1XwSGs-0006VB-0r
	for qemu-devel@nongnu.org; Thu, 04 Dec 2014 04:00:22 -0500
Date: Thu, 4 Dec 2014 04:00:18 -0500 (EST)
From: Francesco Romani <fromani@redhat.com>
Message-ID: <968660888.6461334.1417683618392.JavaMail.zimbra@redhat.com>
In-Reply-To: <1417683548-15845-1-git-send-email-fromani@redhat.com>
References: <1417683548-15845-1-git-send-email-fromani@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] block: add event when disk usage
	exceeds threshold
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com, lcapitulino@redhat.com

----- Original Message -----
> From: "Francesco Romani" <fromani@redhat.com>
> To: qemu-devel@nongnu.org
> Cc: kwolf@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, eblake@redhat.com,
> "Francesco Romani" <fromani@redhat.com>
> Sent: Thursday, December 4, 2014 9:59:08 AM
> Subject: [PATCH v4] block: add event when disk usage exceeds threshold
[...]

Changes since v3:
-----------------

addressed reviewers comments:
- dropped redundant cover letter
- improved commit message to reflect real intended use
  (polling is not going away completely)
- spelling fixes
- API consistency fixes
- kept 'uint64' in QAPI because it is mapped to C type  uint64_t,
  where 'int' is mapped to 'int64_t'
- renamed for consistency everywhere:
  'usage_threshold' => 'write_threshold'

Thanks and best regards

-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani