From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 868E0C388F9 for ; Thu, 22 Oct 2020 15:22:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D80442173E for ; Thu, 22 Oct 2020 15:22:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vpxog/FC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D80442173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVcQL-00035O-RJ for qemu-devel@archiver.kernel.org; Thu, 22 Oct 2020 11:22:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVcPB-0002Fo-H5 for qemu-devel@nongnu.org; Thu, 22 Oct 2020 11:21:31 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:41287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVcP9-0003TG-5G for qemu-devel@nongnu.org; Thu, 22 Oct 2020 11:21:29 -0400 Received: by mail-pg1-x543.google.com with SMTP id n9so1111661pgt.8 for ; Thu, 22 Oct 2020 08:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jgwEEuVg1nvnBDAWncdVnqCa7k74Z4tQ9N9wv/8+FCk=; b=vpxog/FCElgZ4b3/iLENMJW6ZBIo8mEsaWGp9eJaBEEZwFviV/nxTNYrZp4QgB+qP7 BxLfFaOtkBBQJ3GWJbOJPZyBM4ZQaJgH+g1bqMLODy25FzwBe+AUh6+troUjlaxmXLag dk/UsLlTKyNKIFz1Z8g0RZYetc/YqIF8V4YGfi4qEI52n8VK4N9q19sJLbzcr9Y/q6gM nWPJIH3f4sEA/RI5XwFmU6s0gvQCa+v9lnVE7IBeTaaJqB0jMkVzaZQMZR4Ut5pirD12 4vsuKTKqCecIytX5fakBTc6CQjYEzr6bFc61/YRCaERtBqlxBhFo5hRIVc658gBw8JqG UsWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jgwEEuVg1nvnBDAWncdVnqCa7k74Z4tQ9N9wv/8+FCk=; b=uENhtKk3ahmPBLd0hnneBcUsKsaVrZNWlTgPi+rJqYMF+mStrBl8wyIY8d/CHVdWA1 AT1KpRs+Z8C7lzIgx/VPtoKFTEY1lgNT42pl83/423kTiwbkycFUAdgNl78G3edJeml4 6gxT6fItBeM7LX0uH8ZMaXs6yODhYxczOrXJlYq7DSeTEB+6gaGhc18ecRGnsFk6y/DO UZ/F0aWLrV7WBPO0n+wqAInVstCYec2tsUSXL5xRevecOSt34zQCFJu8wd3Pnq4gbodZ 73+34Q2esAglKQYSUIqoiAD2ShxQPHIMIfDWTMOtYQ86GJL+sQqq+PAumto/evyL0bNB tjUA== X-Gm-Message-State: AOAM532lkmgVPGbRf3w/PqZHYfxJkRXWh7lIfPjvTtLn7VNa6qpYyCjv iFUI69lMJSBL6iKr0jIKHihhmA== X-Google-Smtp-Source: ABdhPJxcTnp/af9YlgPZyfAFy7U5Pup6ForWvjDe1SJSTrIpLXwPiCF+oM9QVnzTQgwAEcD5Bb5Q3w== X-Received: by 2002:a63:1d12:: with SMTP id d18mr2748163pgd.314.1603380084737; Thu, 22 Oct 2020 08:21:24 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id q2sm2344858pfu.193.2020.10.22.08.21.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2020 08:21:23 -0700 (PDT) Subject: Re: [PATCH] target/riscv: Adjust privilege level for HLV(X)/HSV instructions To: Alistair Francis References: <20201018120308.1712054-1-georg.kotheimer@kernkonzept.com> From: Richard Henderson Message-ID: <968d33ab-3df9-a043-5462-03f51ccde431@linaro.org> Date: Thu, 22 Oct 2020 08:21:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.107, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , "open list:RISC-V" , Georg Kotheimer , "qemu-devel@nongnu.org Developers" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/21/20 12:21 PM, Alistair Francis wrote: >> mmuidx, you would use cpu_lduw_mmuidx_ra. I would also split the function into >> two, so that one performs HLVX.HU and the other HLVX.WU, so that you don't have >> to pass the size as a parameter. > > I'm not clear what you mean here. target_ulong helper_hyp_x_load(CPURISCVState *env, target_ulong address, target_ulong attrs, target_ulong memop) should be split to target_ulong helper_hlvx_hu(CPURISCVState *env, target_ulong address) target_ulong helper_hlvx_hw(CPURISCVState *env, target_ulong address) (attrs is already unused?) so that memop is not required. r~