* [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus
@ 2019-12-24 11:16 Philippe Mathieu-Daudé
2019-12-24 15:06 ` Stefano Garzarella
2020-01-07 11:23 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-24 11:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Philippe Mathieu-Daudé, Michael S. Tsirkin
The MC146818 sits on an ISA bus. Since it can not be used
without it, select ISA in the Kconfig.
Fixes: 82f5181777e
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig
index 45daa8d655..3dc2dd6888 100644
--- a/hw/rtc/Kconfig
+++ b/hw/rtc/Kconfig
@@ -17,6 +17,7 @@ config TWL92230
depends on I2C
config MC146818RTC
+ depends on ISA_BUS
bool
config SUN4V_RTC
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus
2019-12-24 11:16 [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus Philippe Mathieu-Daudé
@ 2019-12-24 15:06 ` Stefano Garzarella
2020-01-07 11:23 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2019-12-24 15:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Paolo Bonzini, qemu-devel, Michael S. Tsirkin
On Tue, Dec 24, 2019 at 12:16:28PM +0100, Philippe Mathieu-Daudé wrote:
> The MC146818 sits on an ISA bus. Since it can not be used
> without it, select ISA in the Kconfig.
>
> Fixes: 82f5181777e
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
> diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig
> index 45daa8d655..3dc2dd6888 100644
> --- a/hw/rtc/Kconfig
> +++ b/hw/rtc/Kconfig
> @@ -17,6 +17,7 @@ config TWL92230
> depends on I2C
>
> config MC146818RTC
> + depends on ISA_BUS
> bool
>
> config SUN4V_RTC
> --
> 2.21.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus
2019-12-24 11:16 [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus Philippe Mathieu-Daudé
2019-12-24 15:06 ` Stefano Garzarella
@ 2020-01-07 11:23 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-01-07 11:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Michael S. Tsirkin
On 24/12/19 12:16, Philippe Mathieu-Daudé wrote:
> The MC146818 sits on an ISA bus. Since it can not be used
> without it, select ISA in the Kconfig.
>
> Fixes: 82f5181777e
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig
> index 45daa8d655..3dc2dd6888 100644
> --- a/hw/rtc/Kconfig
> +++ b/hw/rtc/Kconfig
> @@ -17,6 +17,7 @@ config TWL92230
> depends on I2C
>
> config MC146818RTC
> + depends on ISA_BUS
> bool
>
> config SUN4V_RTC
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-07 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-24 11:16 [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus Philippe Mathieu-Daudé
2019-12-24 15:06 ` Stefano Garzarella
2020-01-07 11:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).