qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gustavo Romero" <gustavo.romero@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-arm@nongnu.org
Subject: Re: [PATCH 1/4] gdbstub/aarch64: add CurrentEL register
Date: Fri, 8 Aug 2025 10:14:44 -0700	[thread overview]
Message-ID: <96a27883-e02e-4d76-9dde-41ae1a19e0c3@linaro.org> (raw)
In-Reply-To: <CAFEAcA-QcjtkAUUUGVvaUVrJBqP3NvSX0DuXQ==MGcPrjNtGQw@mail.gmail.com>

On 8/8/25 9:14 AM, Peter Maydell wrote:
> On Fri, 8 Aug 2025 at 17:11, Pierrick Bouvier
> <pierrick.bouvier@linaro.org> wrote:
>>
>> On 8/8/25 5:26 AM, Manos Pitsidianakis wrote:
>>> On Fri, Aug 8, 2025 at 3:21 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>>>>
>>>> On Fri, 8 Aug 2025 at 12:30, Manos Pitsidianakis
>>>> <manos.pitsidianakis@linaro.org> wrote:
>>>> The debugger already has this information in the 'cpsr'
>>>> register, so it could implement convenience views of
>>>> the subfields itself if it liked.
>>>
>>> Yep, but consider: it is a register, architecturally, so it's nice to
>>> include it for consistency. It's redundant only because gdb has cpsr
>>> which is not a register. So this is about more about being technically
>>> correct than correcting an actual problem.
>>>
>>
>> I agree with Manos on this.
>> As mentioned on a previous thread, cpsr is not even supposed to exist
>> for aarch64. So adding architecturally defined registers, even if data
>> is redundant with cpsr, should not be a problem.
>> I'm sure gdb folks can understand this too.
> 
> I'm not saying this is the wrong way to represent this.
> I'm just saying we're not the only gdbstub in the world,
> and it would be nice to have a wider discussion than just
> QEMU folks so we are consistent about how we represent
> PSTATE (including what we want to do about the new
> bits that appear in the high 32 bits of an SPSR), before
> we commit to any particular direction.
>

Considering we have our own set of gdb xml, is that really important to 
agree on pstate layout before we simply make those registers visible on 
our side?
The new registers added in this series on gdb/kgdb side at the moment, 
so we don't really break anything.

I agree it would be good to see this on gdb side, but my point is that 
we are not necessarily stuck and we can make this visible without 
waiting two releases. As well, it would be a good motivation to add this 
on gdb showing QEMU already exposes this.

> -- PMM



  reply	other threads:[~2025-08-08 17:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 11:30 [PATCH 0/4] arm: Add PSTATE field registers CurrentEL, NZCV, DAIF, SPSel to gdbstub Manos Pitsidianakis
2025-08-08 11:30 ` [PATCH 1/4] gdbstub/aarch64: add CurrentEL register Manos Pitsidianakis
2025-08-08 12:21   ` Peter Maydell
2025-08-08 12:26     ` Manos Pitsidianakis
2025-08-08 16:11       ` Pierrick Bouvier
2025-08-08 16:14         ` Peter Maydell
2025-08-08 17:14           ` Pierrick Bouvier [this message]
2025-08-08 11:30 ` [PATCH 2/4] gdbstub/aarch64: add NZCV register Manos Pitsidianakis
2025-08-08 11:30 ` [PATCH 3/4] gdbstub/aarch64: add DAIF register Manos Pitsidianakis
2025-08-08 11:30 ` [PATCH 4/4] gdbstub/aarch64: add SPSel register Manos Pitsidianakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96a27883-e02e-4d76-9dde-41ae1a19e0c3@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=gustavo.romero@linaro.org \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).