From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 1/2] usb-mtp: fix utf16_to_str
Date: Mon, 3 Dec 2018 14:00:19 -0600 [thread overview]
Message-ID: <96a5eae1-e2eb-b4ae-35c5-6ebdf864614e@redhat.com> (raw)
In-Reply-To: <20181203195039.29597-2-kraxel@redhat.com>
On 12/3/18 1:50 PM, Gerd Hoffmann wrote:
> Make utf16_to_str return an allocated string. Remove the assumtion that
s/assumtion/assumption/ (but probably too late to worry about commit
typos in a pull request :)
> the number of string bytes equals the number of utf16 chars (which is
> only true for ascii chars). Instead call wcstombs twice, once to figure
> the storage size and once for the actual conversion (as suggested by the
> wcstombs manpage).
>
> FIXME: surrogate pairs are not working correctly. Pre-existing bug,
> fixing that is left for another day.
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-12-03 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 19:50 [Qemu-devel] [PULL 0/2] Fixes 31 20181203 patches Gerd Hoffmann
2018-12-03 19:50 ` [Qemu-devel] [PULL 1/2] usb-mtp: fix utf16_to_str Gerd Hoffmann
2018-12-03 20:00 ` Eric Blake [this message]
2018-12-03 19:50 ` [Qemu-devel] [PULL 2/2] usb-mtp: outlaw slashes in filenames Gerd Hoffmann
2018-12-04 9:36 ` [Qemu-devel] [PULL 0/2] Fixes 31 20181203 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a5eae1-e2eb-b4ae-35c5-6ebdf864614e@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).