From: Richard Henderson <richard.henderson@linaro.org>
To: "Clément Léger" <cleger@rivosinc.com>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v6 5/5] net/tap: Use qemu_close_all_open_fd()
Date: Wed, 31 Jul 2024 12:06:15 +1000 [thread overview]
Message-ID: <96a752c9-0517-4f77-9370-cbdb171cda38@linaro.org> (raw)
In-Reply-To: <20240730122437.1749603-6-cleger@rivosinc.com>
On 7/30/24 22:24, Clément Léger wrote:
> Instead of using a slow implementation to close all open fd after
> forking, use qemu_close_all_open_fd().
>
> Signed-off-by: Clément Léger<cleger@rivosinc.com>
> ---
> net/tap.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2024-07-31 2:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 12:24 [PATCH v6 0/5] qemu/osdep: add a qemu_close_all_open_fd() helper Clément Léger
2024-07-30 12:24 ` [PATCH v6 1/5] qemu/osdep: Move close_all_open_fds() to oslib-posix Clément Léger
2024-07-30 16:10 ` Philippe Mathieu-Daudé
2024-07-31 1:54 ` Richard Henderson
2024-07-30 12:24 ` [PATCH v6 2/5] qemu/osdep: Split qemu_close_all_open_fd() and add fallback Clément Léger
2024-07-31 1:56 ` Richard Henderson
2024-07-30 12:24 ` [PATCH v6 3/5] net/tap: Factorize fd closing after forking Clément Léger
2024-07-30 16:11 ` Philippe Mathieu-Daudé
2024-07-31 1:57 ` Richard Henderson
2024-07-30 12:24 ` [PATCH v6 4/5] qemu/osdep: Add excluded fd parameter to qemu_close_all_open_fd() Clément Léger
2024-07-31 2:03 ` Richard Henderson
2024-07-30 12:24 ` [PATCH v6 5/5] net/tap: Use qemu_close_all_open_fd() Clément Léger
2024-07-31 2:06 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a752c9-0517-4f77-9370-cbdb171cda38@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=cleger@rivosinc.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).