From: Richard Henderson <richard.henderson@linaro.org>
To: Sven Schnelle <svens@stackframe.org>,
Richard Henderson <rth@twiddle.net>
Cc: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip
Date: Mon, 21 Oct 2019 11:26:20 -0700 [thread overview]
Message-ID: <96d555a9-554e-529d-1f0f-84f858dbc55a@linaro.org> (raw)
In-Reply-To: <20191020204724.31537-2-svens@stackframe.org>
On 10/20/19 1:47 PM, Sven Schnelle wrote:
> #define DINO_PCI_HOST_BRIDGE(obj) \
> OBJECT_CHECK(DinoState, (obj), TYPE_DINO_PCI_HOST_BRIDGE)
>
> +#define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4)
> +static uint8_t reg800_keep_bits[DINO800_REGS]
> + = { 1, 7, 7, 8, 7, 9, 32, 8, 30, 25, 22, 9 };
(1) const.
(2) better as a mask:
static const uint32_t reg800_keep_mask[DINO800_REGS] = {
MAKE_64BIT_MASK(0, 1),
MAKE_64BIT_MASK(0, 7),
...
};
since that's the only way this is actually used.
r~
next prev parent reply other threads:[~2019-10-21 18:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 20:47 [PATCH 0/7] HPPA: i82596, PS/2 and graphics emulation Sven Schnelle
2019-10-20 20:47 ` [PATCH 1/7] hw/hppa/dino.c: Improve emulation of Dino PCI chip Sven Schnelle
2019-10-21 18:26 ` Richard Henderson [this message]
2019-10-20 20:47 ` [PATCH 2/7] hppa: Add support for LASI chip with i82596 NIC Sven Schnelle
2019-10-20 20:47 ` [PATCH 3/7] hppa: remove ISA region Sven Schnelle
2019-10-21 18:17 ` Richard Henderson
2019-10-21 20:58 ` Sven Schnelle
2019-10-20 20:47 ` [PATCH 4/7] ps2: accept 'Set Key Make and Break' commands Sven Schnelle
2019-10-20 20:47 ` [PATCH 5/7] hppa: add emulation of LASI PS2 controllers Sven Schnelle
2019-10-20 20:47 ` [PATCH 6/7] hppa: Add emulation of Artist graphics Sven Schnelle
[not found] ` <20191020204724.31537-8-svens@stackframe.org>
2019-10-21 11:24 ` [PATCH 7/7] seabios-hppa: update to latest version Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96d555a9-554e-529d-1f0f-84f858dbc55a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).