From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] tests/decode: Suppress "error: " string for expected-failure tests
Date: Thu, 20 Jul 2023 15:38:18 +0200 [thread overview]
Message-ID: <96da4078-d3c3-7c64-f681-7ebe1df50f85@linaro.org> (raw)
In-Reply-To: <20230720131521.1325905-1-peter.maydell@linaro.org>
On 20/7/23 15:15, Peter Maydell wrote:
> The "expected failure" tests for decodetree result in the
> error messages from decodetree ending up in logs and in
> V=1 output:
>
>>>> MALLOC_PERTURB_=226 /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/x86/pyvenv/bin/python3 /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/scripts/decodetree.py --output-null --test-for-error /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/x86/../../tests/decode/err_argset1.decode
> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/x86/../../tests/decode/err_argset1.decode:5: error: duplicate argument "a"
> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> 1/44 qemu:decodetree / err_argset1 OK 0.05s
>
> This then produces false positives when scanning the
> logfiles for strings like "error: ".
>
> For the expected-failure tests, make decodetree print
> "detected:" instead of "error:".
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> My initial thought was "just get meson to suppress stderr for these
> tests", but AFAICT meson has no way to do that, and we already have a
> command line option to decodetree to request specific behaviour for
> the tests that expect failure, so this seemed simplest.
>
> scripts/decodetree.py | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-20 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 13:15 [PATCH] tests/decode: Suppress "error: " string for expected-failure tests Peter Maydell
2023-07-20 13:38 ` Philippe Mathieu-Daudé [this message]
2023-07-22 12:24 ` Richard Henderson
2023-07-24 13:22 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96da4078-d3c3-7c64-f681-7ebe1df50f85@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).