From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: remove useless padding in flock64 structure
Date: Wed, 2 May 2018 10:33:00 -0700 [thread overview]
Message-ID: <96dc17ed-6e44-032d-0b28-f9ef855f5e73@linaro.org> (raw)
In-Reply-To: <20180502171853.25332-1-laurent@vivier.eu>
On 05/02/2018 10:18 AM, Laurent Vivier wrote:
> +#if defined(TARGET_ARM) && defined(TARGET_ABI32)
> +struct target_oabi_flock64 {
> + abi_short l_type;
> + abi_short l_whence;
> abi_llong l_start;
> abi_llong l_len;
> - int l_pid;
> + abi_int l_pid;
> } QEMU_PACKED;
> #endif
Is it possible to move this to linux-user/arm/target_structs.h?
Otherwise it all looks ok.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2018-05-02 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 17:18 [Qemu-devel] [PATCH v2] linux-user: remove useless padding in flock64 structure Laurent Vivier
2018-05-02 17:33 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96dc17ed-6e44-032d-0b28-f9ef855f5e73@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).