From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3683BC02192 for ; Mon, 3 Feb 2025 10:16:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tetUf-0000om-GZ; Mon, 03 Feb 2025 05:15:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tetUc-0000oZ-LE for qemu-devel@nongnu.org; Mon, 03 Feb 2025 05:15:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tetUY-0006uY-Kk for qemu-devel@nongnu.org; Mon, 03 Feb 2025 05:15:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738577744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pwNTvoxmKEiCffM7UzC+KnHJERKaALGbZf6XF4Dj41I=; b=gnTg4MGL/EcQMtI/zUysFU3nGoKi3Z1IFfZMcGFjmeE4DpVHq0HiXvbOHF4gpEIx7GFFP3 4cT0j/3J8A3ke0OMzHY0X3iF4/VKjgla/tfn/3A7Bsch3Q47UoHstr5MQCPrQVYxzWigKP 4+HSssFh7tu0a5KNLkGBym5RxnUm4xo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-0wjXW0n_OcqcIhEU6bxohg-1; Mon, 03 Feb 2025 05:15:43 -0500 X-MC-Unique: 0wjXW0n_OcqcIhEU6bxohg-1 X-Mimecast-MFC-AGG-ID: 0wjXW0n_OcqcIhEU6bxohg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361d4e8359so29167385e9.3 for ; Mon, 03 Feb 2025 02:15:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738577742; x=1739182542; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pwNTvoxmKEiCffM7UzC+KnHJERKaALGbZf6XF4Dj41I=; b=hb7pUbqyd2F5DFkuAJSSfNGUFL9UZ1hb74VBh/BLL7NbJZx4Lph+/zkflYhJe9Q5xx BqmHQ00ulBpT/41p0WEds+BQAlepAb1cqzZ0dXQ2wieMwSCGJeOXkI/XnrFXnTm00Z6U POfNTDcriU148/YaP7F4AHjQF1K+f8vV8ZIiFdrNXu8ZB7yzAkbqiYRrQTV7wvlTgvGq WK4kTXivtvENxMgY3ylB2ge1zfKOsq/znZrkPzgqoMf6iYpkTybPufEvV5dN8cx4h17N zkYBE8TJs2ucD3QiEEBGPGTn9a+Bpqba6wYyjWDqB/U5xkfPJu6b1t0ONVuxk9id6/xh q2xQ== X-Forwarded-Encrypted: i=1; AJvYcCXwUkIuFCD84ABfGH6dugVLyf+vtwFnP79YzHZdURbwezlsn13WOwtn3rRNlwdHJDlrkUycKLyaMn0e@nongnu.org X-Gm-Message-State: AOJu0Yx0MTwWgHD2072vsT19XpLhLLcKRv3LwxEqapcGpn3ndc07/RcA CmudHSVYtBd0GQFtYqQW5AIQy+Cqe35lh8NRlvwbVd+zQQ+MyQD4hhEEdrsSQOwkTtD1MrkZwk5 CwihLgv0KxyGJLc/ffIaWOBuSGt/WelxPi8Ew+B0deXr4xwN8Z0dA X-Gm-Gg: ASbGncv6S6dAwFc9b0YyTgkdvVk8AQaDl9RUdlxTORFF2DcT+1N0iwrM+F9X1UEpBVJ 4KxfC6bQ1wdQGJMtR/6KELJNHH7Pd3mLFQjOBU1bTrf1Ey/30Co2U6n6dgLS5gOm6Q1DRGDwWs6 UFwZQk8PFH5K+mq4F2jQSE3jGgoYDItwcYhGlznrmgpkrNfVLRoWiYXAofb/adf2nF94ZgrqwlV V6DBWcUFExIn5czH0fUOoQLHg3cr5U0sgfFWlckfn+Yz8tMfwC/xjMm1EPXe8n23Smk+Z7n4X7c wFnBqSU7A3iyjYUHeEd6I60MsBL89g== X-Received: by 2002:a05:600c:19d2:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438dc34b37bmr201498885e9.0.1738577741831; Mon, 03 Feb 2025 02:15:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFyHROglnWjdDSNB2A5WWSKVB7mL5ONUz6UmrqIMxNXHvwwNFUMfXh5Z58GfwsnpF8KnbQAg== X-Received: by 2002:a05:600c:19d2:b0:435:330d:de86 with SMTP id 5b1f17b1804b1-438dc34b37bmr201498645e9.0.1738577741502; Mon, 03 Feb 2025 02:15:41 -0800 (PST) Received: from [10.33.192.228] (nat-pool-str-t.redhat.com. [149.14.88.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e23de880sm148543255e9.12.2025.02.03.02.15.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2025 02:15:41 -0800 (PST) Message-ID: <96dd504f-4df4-478c-9c5e-65e0341ab7ca@redhat.com> Date: Mon, 3 Feb 2025 11:15:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/14] tcg: Link only when required in system mode To: Richard Henderson , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mark.cave-ayland@ilande.co.uk, berrange@redhat.com, philmd@linaro.org References: <20250203031821.741477-1-richard.henderson@linaro.org> <20250203031821.741477-6-richard.henderson@linaro.org> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250203031821.741477-6-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 03/02/2025 04.18, Richard Henderson wrote: > Rather than unconditional linkage via system_ss, conditinally > include the static library via specific_ss. This will elide > the code when CONFIG_TCG is disabled for a specific target. > > Signed-off-by: Richard Henderson > --- > tcg/meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tcg/meson.build b/tcg/meson.build > index 2977df5862..8266bcb324 100644 > --- a/tcg/meson.build > +++ b/tcg/meson.build > @@ -49,4 +49,8 @@ libtcg_system = static_library('tcg_system', > > tcg_system = declare_dependency(objects: libtcg_system.extract_all_objects(recursive: false), > dependencies: tcg_ss.dependencies()) > -system_ss.add(tcg_system) > + > +specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: tcg_system) > +if host_os == 'linux' > + specific_ss.add(when: 'CONFIG_TCG', if_false: files('perf-stubs.c')) > +endif Reviewed-by: Thomas Huth