qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Havard Skinnemoen <hskinnemoen@google.com>, peter.maydell@linaro.org
Cc: venture@google.com, qemu-devel@nongnu.org, wuhaotsh@google.com,
	kfting@nuvoton.com, qemu-arm@nongnu.org, Avi.Fishman@nuvoton.com
Subject: Re: [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator
Date: Thu, 22 Oct 2020 07:58:03 +0200	[thread overview]
Message-ID: <96e31c8b-2339-975a-bab0-5693cd02e09a@redhat.com> (raw)
In-Reply-To: <20201021213544.3399271-4-hskinnemoen@google.com>

On 21/10/2020 23.35, Havard Skinnemoen via wrote:
> The RNG module returns a byte of randomness when the Data Valid bit is
> set.
> 
> This implementation ignores the prescaler setting, and loads a new value
> into RNGD every time RNGCS is read while the RNG is enabled and random
> data is available.
> 
> A qtest featuring some simple randomness tests is included.
> 
> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com>
> ---
[...]
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index f7b0e3ca9d..473935c3a8 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -140,6 +140,7 @@ qtests_arm = \
>     'm25p80-test',
>     'npcm7xx_timer-test',
>     'npcm7xx_watchdog_timer-test',
> +   'npcm7xx_rng-test',
>     'test-arm-mptimer',
>     'boot-serial-test',
>     'hexloader-test']

Please fence this with CONFIG_NPCM7XX, too.

 Thanks,
  Thomas




  reply	other threads:[~2020-10-22  5:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 21:35 [PATCH v2 0/5] Additional NPCM7xx features, devices and tests Havard Skinnemoen via
2020-10-21 21:35 ` [PATCH v2 1/5] Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause Havard Skinnemoen via
2020-10-21 21:35 ` [PATCH v2 2/5] hw/timer: Adding watchdog for NPCM7XX Timer Havard Skinnemoen via
2020-10-22  5:56   ` Thomas Huth
2020-10-21 21:35 ` [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator Havard Skinnemoen via
2020-10-22  5:58   ` Thomas Huth [this message]
2020-10-21 21:35 ` [PATCH v2 4/5] hw/arm/npcm7xx: Add EHCI and OHCI controllers Havard Skinnemoen via
2020-10-21 21:35 ` [PATCH v2 5/5] hw/gpio: Add GPIO model for Nuvoton NPCM7xx Havard Skinnemoen via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96e31c8b-2339-975a-bab0-5693cd02e09a@redhat.com \
    --to=thuth@redhat.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=hskinnemoen@google.com \
    --cc=kfting@nuvoton.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=venture@google.com \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).