From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073D1C388F7 for ; Thu, 22 Oct 2020 05:59:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 732E22225F for ; Thu, 22 Oct 2020 05:59:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h04KHuib" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 732E22225F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVTdQ-0005u7-CZ for qemu-devel@archiver.kernel.org; Thu, 22 Oct 2020 01:59:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVTcA-0005AU-Ol for qemu-devel@nongnu.org; Thu, 22 Oct 2020 01:58:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVTc8-0003GD-CU for qemu-devel@nongnu.org; Thu, 22 Oct 2020 01:58:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603346293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u0By4YvDUOGxz/k0AI3JmlO+7SFpsS7BdlQBVD9xAYw=; b=h04KHuibbbTGxX6AsrSznWsEEIUtp28DxY9zvTfxLKpwzuoowTEEvkygImQOqM3ig8zIYd tfFOty2Lov4tOyHTJCZVjhhaSyuhl8f5/vFJbBISKD1sOYzyKfygtXKOrvEmekI6QhGq8S QB7up6n5sG1tvKSr2ppgw+dlI2+XoN4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-6-t1gR-nOV-GdcU0WkLNuw-1; Thu, 22 Oct 2020 01:58:09 -0400 X-MC-Unique: 6-t1gR-nOV-GdcU0WkLNuw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4F7B186DD54; Thu, 22 Oct 2020 05:58:07 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-77.ams2.redhat.com [10.36.112.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id C48C76EF41; Thu, 22 Oct 2020 05:58:04 +0000 (UTC) Subject: Re: [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator To: Havard Skinnemoen , peter.maydell@linaro.org References: <20201021213544.3399271-1-hskinnemoen@google.com> <20201021213544.3399271-4-hskinnemoen@google.com> From: Thomas Huth Message-ID: <96e31c8b-2339-975a-bab0-5693cd02e09a@redhat.com> Date: Thu, 22 Oct 2020 07:58:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201021213544.3399271-4-hskinnemoen@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/21 23:30:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: venture@google.com, qemu-devel@nongnu.org, wuhaotsh@google.com, kfting@nuvoton.com, qemu-arm@nongnu.org, Avi.Fishman@nuvoton.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21/10/2020 23.35, Havard Skinnemoen via wrote: > The RNG module returns a byte of randomness when the Data Valid bit is > set. > > This implementation ignores the prescaler setting, and loads a new value > into RNGD every time RNGCS is read while the RNG is enabled and random > data is available. > > A qtest featuring some simple randomness tests is included. > > Reviewed-by: Tyrone Ting > Reviewed-by: Peter Maydell > Signed-off-by: Havard Skinnemoen > --- [...] > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index f7b0e3ca9d..473935c3a8 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -140,6 +140,7 @@ qtests_arm = \ > 'm25p80-test', > 'npcm7xx_timer-test', > 'npcm7xx_watchdog_timer-test', > + 'npcm7xx_rng-test', > 'test-arm-mptimer', > 'boot-serial-test', > 'hexloader-test'] Please fence this with CONFIG_NPCM7XX, too. Thanks, Thomas