From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnNIY-0004U7-2e for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:10:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnNIU-0004Fa-K0 for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:10:41 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45690 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnNIU-0004F4-9p for qemu-devel@nongnu.org; Wed, 08 Aug 2018 08:10:38 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D23C481663F6 for ; Wed, 8 Aug 2018 12:10:37 +0000 (UTC) References: <20180808114830.7169-1-quintela@redhat.com> <20180808114830.7169-7-quintela@redhat.com> From: Thomas Huth Message-ID: <96e995b7-9dec-05af-5835-ab200bb1a743@redhat.com> Date: Wed, 8 Aug 2018 14:10:34 +0200 MIME-Version: 1.0 In-Reply-To: <20180808114830.7169-7-quintela@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 06/22] i386-softmmu: Configuration is identical to x86_64-softmmu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com, Paolo Bonzini On 08/08/2018 01:48 PM, Juan Quintela wrote: > If we ever changed that, just make the things that are different > explicit. > > Signed-off-by: Juan Quintela > --- > default-configs/i386-softmmu.mak | 65 +------------------------------- > 1 file changed, 1 insertion(+), 64 deletions(-) > > diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak > index 8827166ba1..6ec7a3b0ae 100644 > --- a/default-configs/i386-softmmu.mak > +++ b/default-configs/i386-softmmu.mak > @@ -1,66 +1,3 @@ > # Default configuration for i386-softmmu > > -include pci.mak > -include sound.mak > -include usb.mak > -CONFIG_QXL=$(CONFIG_SPICE) > -CONFIG_VGA_ISA=y > -CONFIG_VGA_CIRRUS=y > -CONFIG_VMWARE_VGA=y > -CONFIG_VMXNET3_PCI=y > -CONFIG_VIRTIO_VGA=y > -CONFIG_VMMOUSE=y > -CONFIG_IPMI=y > -CONFIG_IPMI_LOCAL=y > -CONFIG_IPMI_EXTERN=y > -CONFIG_ISA_IPMI_KCS=y > -CONFIG_ISA_IPMI_BT=y > -CONFIG_PARALLEL=y > -CONFIG_I8254=y > -CONFIG_PCSPK=y > -CONFIG_PCKBD=y > -CONFIG_FDC=y > -CONFIG_ACPI=y > -CONFIG_ACPI_X86=y > -CONFIG_ACPI_X86_ICH=y > -CONFIG_ACPI_MEMORY_HOTPLUG=y > -CONFIG_ACPI_CPU_HOTPLUG=y > -CONFIG_APM=y > -CONFIG_I8257=y > -CONFIG_IDE_ISA=y > -CONFIG_IDE_PIIX=y > -CONFIG_NE2000_ISA=y > -CONFIG_HPET=y > -CONFIG_APPLESMC=y > -CONFIG_I8259=y > -CONFIG_PFLASH_CFI01=y > -CONFIG_TPM_TIS=$(CONFIG_TPM) > -CONFIG_TPM_CRB=$(CONFIG_TPM) > -CONFIG_MC146818RTC=y > -CONFIG_PCI_PIIX=y > -CONFIG_WDT_IB700=y > -CONFIG_ISA_DEBUG=y > -CONFIG_ISA_TESTDEV=y > -CONFIG_VMPORT=y > -CONFIG_SGA=y > -CONFIG_LPC_ICH9=y > -CONFIG_PCI_Q35=y > -CONFIG_APIC=y > -CONFIG_IOAPIC=y > -CONFIG_PVPANIC=y > -CONFIG_MEM_HOTPLUG=y > -CONFIG_NVDIMM=y > -CONFIG_ACPI_NVDIMM=y > -CONFIG_PCIE_PORT=y > -CONFIG_XIO3130=y > -CONFIG_IOH3420=y > -CONFIG_I82801B11=y > -CONFIG_SMBIOS=y > -CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM) > -CONFIG_PXB=y > -CONFIG_ACPI_VMGENID=y > -CONFIG_FW_CFG_DMA=y > -CONFIG_I2C=y > -CONFIG_SEV=$(CONFIG_KVM) > -CONFIG_VTD=y > -CONFIG_AMD_IOMMU=y > +include x86_64-softmmu.mak That's theoretically a good idea, but I think I'd rather do it the other way round: include i386-softmmu.mak in the x86_64 config file. Rationale: x86_64 is supposed to be a superset of i386, not the other way round, so when we will ever get a CONFIG_SWITCH_FOR_X86_64_ONLY, it's easier to handle if the includes are done the other way round. And that's also how we do it in aarch64-softmmu.mak an ppc64-softmmu.mak. Thomas