From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTnYB-0006W7-Li for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTnY3-0006RI-9t for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:15 -0400 Received: from [199.232.76.173] (port=40177 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTnY2-0006R8-0w for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:10 -0400 Received: from hera.kernel.org ([140.211.167.34]:55246) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTnY1-0001dt-Ht for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:09 -0400 From: Max Krasnyansky Date: Fri, 15 Aug 2008 00:51:48 +0000 Message-Id: <96efd57549c0ccebae1b7ecc49065c3f28bd996b.1218760447.git.maxk@kernel.org> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 6/8] husb: remove disconnect detection timer Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws, qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Max Krasnyansky On top of my previous USB patchset. Async completion handler can detect device disconnects without polling. We do not need the timer anymore. Signed-off-by: Max Krasnyansky --- usb-linux.c | 37 ++++++------------------------------- 1 files changed, 6 insertions(+), 31 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 786ef1b..dd78bb6 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -82,11 +82,10 @@ typedef struct USBHostDevice { uint8_t descr[1024]; int descr_len; int configuration; + int closing; struct endp_data endp_table[MAX_ENDPOINTS]; - QEMUTimer *timer; - /* Host side address */ int bus_num; int addr; @@ -186,7 +185,7 @@ static void async_complete(void *opaque) if (errno == EAGAIN) return; - if (errno == ENODEV) { + if (errno == ENODEV && !s->closing) { printf("husb: device %d.%d disconnected\n", s->bus_num, s->addr); usb_device_del_addr(0, s->dev.addr); return; @@ -328,7 +327,8 @@ static void usb_host_handle_destroy(USBDevice *dev) { USBHostDevice *s = (USBHostDevice *)dev; - qemu_del_timer(s->timer); + s->closing = 1; + qemu_set_fd_handler(s->fd, NULL, NULL, NULL); hostdev_unlink(s); @@ -582,22 +582,6 @@ static int usb_linux_update_endp_table(USBHostDevice *s) return 0; } -static void usb_host_device_check(void *priv) -{ - USBHostDevice *s = priv; - struct usbdevfs_connectinfo ci; - int err; - - err = ioctl(s->fd, USBDEVFS_CONNECTINFO, &ci); - if (err < 0) { - printf("husb: device %d.%d disconnected\n", s->bus_num, s->addr); - usb_device_del_addr(0, s->dev.addr); - return; - } - - qemu_mod_timer(s->timer, qemu_get_clock(rt_clock) + 1000); -} - static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *prod_name) { int fd = -1, ret; @@ -612,10 +596,6 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p dev->bus_num = bus_num; dev->addr = addr; - dev->timer = qemu_new_timer(rt_clock, usb_host_device_check, (void *) dev); - if (!dev->timer) - goto fail; - printf("husb: open device %d.%d\n", bus_num, addr); snprintf(buf, sizeof(buf), USBDEVFS_PATH "/%03d/%03d", @@ -683,19 +663,14 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p /* USB devio uses 'write' flag to check for async completions */ qemu_set_fd_handler(dev->fd, NULL, async_complete, dev); - /* Start the timer to detect disconnect */ - qemu_mod_timer(dev->timer, qemu_get_clock(rt_clock) + 1000); - hostdev_link(dev); return (USBDevice *) dev; fail: - if (dev) { - if (dev->timer) - qemu_del_timer(dev->timer); + if (dev) qemu_free(dev); - } + close(fd); return NULL; } -- 1.5.5.1