From: Hanna Czenczek <hreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Fam Zheng <fam@euphon.net>,
Fiona Ebner <f.ebner@proxmox.com>, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v3 2/4] qemu-io: use BdrvRequestFlags instead of int
Date: Tue, 7 Feb 2023 12:47:48 +0100 [thread overview]
Message-ID: <96fbe66c-53ed-fa78-0db8-e8047d230c63@redhat.com> (raw)
In-Reply-To: <20230201152751.270508-3-stefanha@redhat.com>
On 01.02.23 16:27, Stefan Hajnoczi wrote:
> The block layer APIs use BdrvRequestFlags while qemu-io code uses int.
> Although the code compiles and runs fine, BdrvRequestFlags is clearer
> because it differentiates between other types of flags like bdrv_open()
> flags.
>
> This is purely refactoring.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-io-cmds.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
With a rebase on264dcbb2b1e5b66d7a5b08662b200c2b315dce0f:
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
next prev parent reply other threads:[~2023-02-07 11:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:27 [PATCH v3 0/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF Stefan Hajnoczi
2023-02-01 15:27 ` [PATCH v3 1/4] " Stefan Hajnoczi
2023-02-07 11:48 ` Hanna Czenczek
2023-02-01 15:27 ` [PATCH v3 2/4] qemu-io: use BdrvRequestFlags instead of int Stefan Hajnoczi
2023-02-07 11:47 ` Hanna Czenczek [this message]
2023-02-01 15:27 ` [PATCH v3 3/4] qemu-io: add -r option to register I/O buffer Stefan Hajnoczi
2023-02-07 11:47 ` Hanna Czenczek
2023-02-07 19:32 ` Stefan Hajnoczi
2023-02-01 15:27 ` [PATCH v3 4/4] iotests/detect-zeroes-registered-buf: add new test Stefan Hajnoczi
2023-02-07 11:51 ` Hanna Czenczek
2023-02-06 21:01 ` [PATCH v3 0/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fbe66c-53ed-fa78-0db8-e8047d230c63@redhat.com \
--to=hreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).