From: Richard Henderson <richard.henderson@linaro.org>
To: Weiwei Li <liweiwei@iscas.ac.cn>,
palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, qemu-riscv@nongnu.org,
qemu-devel@nongnu.org
Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com
Subject: Re: [PATCH v2 5/8] target/riscv: add support for Zcmp extension
Date: Tue, 15 Nov 2022 23:44:19 +1000 [thread overview]
Message-ID: <9713c707-2828-5436-dbd4-60fbd18985f6@linaro.org> (raw)
In-Reply-To: <20221113023251.11047-6-liweiwei@iscas.ac.cn>
On 11/13/22 12:32, Weiwei Li wrote:
> {
> sq 101 ... ... .. ... 10 @c_sqsp
> c_fsd 101 ...... ..... 10 @c_sdsp
> +
> + # *** RV64 and RV32 Zcmp Extension ***
> + cm_push 101 11000 .... .. 10 @zcmp
> + cm_pop 101 11010 .... .. 10 @zcmp
> + cm_popret 101 11110 .... .. 10 @zcmp
> + cm_popretz 101 11100 .... .. 10 @zcmp
> + cm_mva01s 101 011 ... 11 ... 10 @cm_mv
> + cm_mvsa01 101 011 ... 01 ... 10 @cm_mv
> }
There is no overlap in these, so they should be within nested [].
> diff --git a/target/riscv/zce_helper.c b/target/riscv/zce_helper.c
> new file mode 100644
> index 0000000000..1346de1367
> --- /dev/null
> +++ b/target/riscv/zce_helper.c
> @@ -0,0 +1,210 @@
> +/*
> + * RISC-V Zc* extension Helpers for QEMU.
> + *
> + * Copyright (c) 2021-2022 PLCT Lab
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2 or later, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program. If not, see <http://www.gnu.org/licenses/>.
> + */
The entire contents of this helper file should be handled at translation time.
r~
next prev parent reply other threads:[~2022-11-15 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 2:32 [PATCH v2 0/8] support subsets of code size reduction extension Weiwei Li
2022-11-13 2:32 ` [PATCH v2 1/8] target/riscv: add cfg properties for Zc* extension Weiwei Li
2022-11-13 2:32 ` [PATCH v2 2/8] target/riscv: add support for Zca and Zcf extensions Weiwei Li
2022-11-13 21:40 ` Richard Henderson
2022-11-14 3:17 ` weiwei
2022-11-13 2:32 ` [PATCH v2 3/8] target/riscv: add support for Zcd extension Weiwei Li
2022-11-15 12:50 ` Richard Henderson
2022-11-13 2:32 ` [PATCH v2 4/8] target/riscv: add support for Zcb extension Weiwei Li
2022-11-13 2:32 ` [PATCH v2 5/8] target/riscv: add support for Zcmp extension Weiwei Li
2022-11-15 13:44 ` Richard Henderson [this message]
2022-11-16 1:22 ` weiwei
2022-11-13 2:32 ` [PATCH v2 6/8] target/riscv: add support for Zcmt extension Weiwei Li
2022-11-13 2:32 ` [PATCH v2 7/8] target/riscv: expose properties for Zc* extension Weiwei Li
2022-11-13 2:32 ` [PATCH v2 8/8] disas/riscv.c: add disasm support for Zc* Weiwei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9713c707-2828-5436-dbd4-60fbd18985f6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=lazyparser@gmail.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).