From: David Hildenbrand <david@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>,
Cornelia Huck <cohuck@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Andreas Krebbel <krebbel@linux.ibm.com>
Subject: Re: [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting
Date: Thu, 10 Jun 2021 11:49:08 +0200 [thread overview]
Message-ID: <972102fd-ac1e-f13c-7aa7-ad6c7a9be67e@redhat.com> (raw)
In-Reply-To: <20210602002210.3144559-1-iii@linux.ibm.com>
On 02.06.21 02:22, Ilya Leoshkevich wrote:
> qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it
> should be a pointer to the instruction following the illegal
> instruction, but at the moment it is a pointer to the illegal
> instruction itself. This breaks OpenJDK, which relies on this value.
>
> Patch 1 fixes the issue, patch 2 adds a test.
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06592.html
> v1 -> v2: Use a better buglink (Cornelia), simplify the inline asm
> magic in the test and add an explanation (David).
>
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06649.html
> v2 -> v3: Fix SIGSEGV handling (found when trying to run valgrind under
> qemu-user).
>
There might still be something wrong:
https://gitlab.com/qemu-project/qemu/-/issues/319
At least it smells like some more signal (mis)handling.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-06-10 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 0:22 [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting Ilya Leoshkevich
2021-06-02 0:22 ` [PATCH v3 1/2] " Ilya Leoshkevich
2021-06-02 0:22 ` [PATCH v3 2/2] tests/tcg/s390x: Test SIGILL and SIGSEGV handling Ilya Leoshkevich
2021-06-18 13:47 ` jonathan.albrecht
2021-06-21 11:58 ` Ilya Leoshkevich
2021-06-02 0:27 ` [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting no-reply
2021-06-10 9:49 ` David Hildenbrand [this message]
2021-06-10 9:53 ` Christian Borntraeger
2021-06-21 12:00 ` Ilya Leoshkevich
2021-06-21 13:12 ` jonathan.albrecht
2021-06-21 13:44 ` Ilya Leoshkevich
2021-06-21 14:46 ` jonathan.albrecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972102fd-ac1e-f13c-7aa7-ad6c7a9be67e@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=iii@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).