From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFDAC433E2 for ; Fri, 4 Sep 2020 13:22:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 630A2206F2 for ; Fri, 4 Sep 2020 13:22:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UQeEJGjo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 630A2206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEBfl-0005xB-P8 for qemu-devel@archiver.kernel.org; Fri, 04 Sep 2020 09:22:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEBf5-0005Sq-PK for qemu-devel@nongnu.org; Fri, 04 Sep 2020 09:21:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kEBf4-0003Wp-8H for qemu-devel@nongnu.org; Fri, 04 Sep 2020 09:21:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599225708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+3dYKrlqbPGf+nB/veafefvtqUB2clowDo2xAKXstvk=; b=UQeEJGjoOjxZFLbAq7+mMP61KtqYGciygXVaAioyRUCgwJtrwCIbt0xS17WvWNd/6MwMr+ WYwYILAHFpaDHvFHCc39MwhC5wlnnsasDMiLiEV8IzyBfhaIwxGQgwzRRhh3NQEtOSF+Ae ixddTsz4bbVHblipr6BevYprrxCNjGI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-asgAV3ojNhO2E55tozE8pQ-1; Fri, 04 Sep 2020 09:21:46 -0400 X-MC-Unique: asgAV3ojNhO2E55tozE8pQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1CEFAAF20B; Fri, 4 Sep 2020 13:21:45 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-114-156.ams2.redhat.com [10.36.114.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56E1C19C59; Fri, 4 Sep 2020 13:21:43 +0000 (UTC) Subject: Re: [PATCH v8 6/7] block-stream: freeze link to base node during stream job To: Andrey Shinkevich , qemu-block@nongnu.org References: <1598633579-221780-1-git-send-email-andrey.shinkevich@virtuozzo.com> <1598633579-221780-7-git-send-email-andrey.shinkevich@virtuozzo.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <9739719d-0681-d839-cf8d-398b78b6d323@redhat.com> Date: Fri, 4 Sep 2020 15:21:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1598633579-221780-7-git-send-email-andrey.shinkevich@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JnE4SkY2vRWfpc9kXS3NcTAk1FL1baUoB" Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/04 06:46:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.107, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JnE4SkY2vRWfpc9kXS3NcTAk1FL1baUoB Content-Type: multipart/mixed; boundary="EytuS1x1mMLO37doENorB1woVsHo1gB1F" --EytuS1x1mMLO37doENorB1woVsHo1gB1F Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 28.08.20 18:52, Andrey Shinkevich wrote: > To keep the base node unchanged during the block-stream operation, > freeze it as the other part of the backing chain with the intermediate > nodes related to the job. > This patch revers the change made with the commit c624b015bf as the > correct base file name and its format have to be written down to the > QCOW2 header on the disk when the backing file is being changed after > the stream job completes. > This reversion incurs changes in the tests 030, 245 and discards the > test 258 where concurrent stream/commit jobs are tested. When the link > to a base node is frozen, the concurrent job cannot change the common > backing chain. >=20 > Signed-off-by: Andrey Shinkevich > --- > block/stream.c | 29 ++------ > tests/qemu-iotests/030 | 10 +-- > tests/qemu-iotests/245 | 2 +- > tests/qemu-iotests/258 | 161 ---------------------------------------= ------ > tests/qemu-iotests/258.out | 33 ---------- > 5 files changed, 14 insertions(+), 221 deletions(-) > delete mode 100755 tests/qemu-iotests/258 > delete mode 100644 tests/qemu-iotests/258.out Does this need to be in this series? (I=E2=80=99m not entirely sure, based= on what I can see in patch 7.) When doing this, should we introduce a @bottom-node option alongside, so that we can make all the tests that are deleted here pass still, just with changes? Max --EytuS1x1mMLO37doENorB1woVsHo1gB1F-- --JnE4SkY2vRWfpc9kXS3NcTAk1FL1baUoB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl9SP2UACgkQ9AfbAGHV z0DU0Qf9GrJYuB06j2yzJsa+ps0oYgNaaDvAPD7s2L4tsBM5bs5nCUz9gT3zAmzc zofZA5R1kk4+dtNwBpwL5fqgyGJ1s17yotz4zC2QxpAa5Up5D/Wb9eqkpvS9mdSF SxFkwMMwpehjTqObxmrg14G63miQ8TSpUIOWSTRMRZCRDJ/SGTm7b+y55qukRZaW T0nQWI/fhjkIygch+0+wOz3IX+GqyeyufEOhX0dtYt+Y4bpZIOmZkB9AW+q4RiMB 59V8qVvzFJ114rl2X/jYolAx7FXWI/eNo6WQ9LfoVse+r4SnER+QX+rSD4oSmQS2 uwTfBoNvvh+unWh/nB59lPoeRalAcQ== =+Xou -----END PGP SIGNATURE----- --JnE4SkY2vRWfpc9kXS3NcTAk1FL1baUoB--