qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/5] target/tricore: Don't save pc in generate_qemu_excp
Date: Mon, 1 Jun 2020 12:48:25 -0700	[thread overview]
Message-ID: <973dfb31-169f-0f1c-c192-41c064ab2b50@linaro.org> (raw)
In-Reply-To: <20200529072148.284037-2-kbastian@mail.uni-paderborn.de>

On 5/29/20 12:21 AM, Bastian Koppelmann wrote:
> EXCP_DEBUG is the only user. If we encounter a jump in tricore-gdb it's
> target was overwritten by generate_qemu_excp() and we would never leave.
> 
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
>  target/tricore/translate.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2020-06-01 19:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  7:21 [PATCH v2 0/5] TriCore fixes and gdbstub Bastian Koppelmann
2020-05-29  7:21 ` [PATCH v2 1/5] target/tricore: Don't save pc in generate_qemu_excp Bastian Koppelmann
2020-06-01 19:48   ` Richard Henderson [this message]
2020-05-29  7:21 ` [PATCH v2 2/5] target/tricore: Move translate feature check to ctx Bastian Koppelmann
2020-06-01 19:49   ` Richard Henderson
2020-05-29  7:21 ` [PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep Bastian Koppelmann
2020-06-01 21:04   ` Richard Henderson
2020-05-29  7:21 ` [PATCH v2 4/5] target/tricore: Implement tricore_cpu_get_phys_page_debug Bastian Koppelmann
2020-06-01 21:17   ` Richard Henderson
2020-05-29  7:21 ` [PATCH v2 5/5] target/tricore: Implement gdbstub Bastian Koppelmann
2020-05-29  8:31   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=973dfb31-169f-0f1c-c192-41c064ab2b50@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).