From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C202C3A59E for ; Wed, 21 Aug 2019 15:13:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54471216F4 for ; Wed, 21 Aug 2019 15:13:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oaF/DoJM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54471216F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49337 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0SIR-00061W-4h for qemu-devel@archiver.kernel.org; Wed, 21 Aug 2019 11:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44951) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0SFN-0001us-Qk for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:10:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0SFM-0002T5-Ju for qemu-devel@nongnu.org; Wed, 21 Aug 2019 11:10:01 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:39497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0SFM-0002SD-EZ; Wed, 21 Aug 2019 11:10:00 -0400 Received: by mail-pl1-x644.google.com with SMTP id z3so1490834pln.6; Wed, 21 Aug 2019 08:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/2kcX3vntX5/cxws0OYeICfLeOq4JTTwSz2UmwBIlYA=; b=oaF/DoJMNMaaa2iM5pZZVUOMNnvDV0irrBuFDtEkdrMaHlEKD31AaF/7t3Im9MfoDg Qbd+f5GD4dq2kyUgCmaWgJSt7sgB7p37w/jw4muDAMESPJrvsAqNitntEZsjeMiyo/rF cN/Psgsx5U1csmTzRUM/CibvuUEf+NWEKQvoZ8Pt+mxdi2GY/zAZOiY55pPHh7oP5vLr rg8Vm4mA/23f+NgcboO1DRLr0yzXH4BDvB8oy0rdo0hfDFjtksF5jcEgWld8ABWdD44i MZa5MaHl3rGLpARU99hbnhLhq5R+LSJ1rqIRtS3R5z4KxmdifaUv1BWT72raPShUV/Ne 3C2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/2kcX3vntX5/cxws0OYeICfLeOq4JTTwSz2UmwBIlYA=; b=tMyy23RSK07I2UU5DOcpHJ6JYV6RpKPSjUoyRphMXUUkL/qQ629JgTJjLnbCfOOLQI JT1fXrG3HV6FET30kyb8f8wpiXSttMYSCf06wV9RlAjv9GMefFw7TwpAr5Wr+/jAmrsJ tKcrd65gFMYD0obh0b27zMDTpaKOkb0HZAbJSpQDsnnLzVcrSdnnraGb1hySp9nlPt6v XK4N5UYnOz1zE+iqP2ucJYFfsh5WO3P7UyymULX2j+sP0q7Z2Z93W74l7Pd3oBTp5UAj MT2913+TaSZp6uRryUJNZqnti1W7d40K37yntrgaXZuUstoAyr2qKuIK97rtvKGngN2y CDXg== X-Gm-Message-State: APjAAAWg4dJoBBnYpF79lLmzOCbe0NLWlq83WT+RI7JBV+iw6XLogaA0 zpU19lW4FLlBJWz0vfAIBprirGwE3D8= X-Google-Smtp-Source: APXvYqz11v5bYlRHZ6rmSoQ7aDNSSQjnhxbh/1PbgXRN00TkdDndZE4v0qA2BZaGdrcnD6Kikg4QSw== X-Received: by 2002:a17:902:2bc5:: with SMTP id l63mr31956117plb.239.1566400199398; Wed, 21 Aug 2019 08:09:59 -0700 (PDT) Received: from localhost.localdomain ([58.173.98.68]) by smtp.gmail.com with ESMTPSA id e19sm5887633pfh.114.2019.08.21.08.09.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Aug 2019 08:09:59 -0700 (PDT) From: Tony Nguyen To: qemu-devel@nongnu.org Date: Thu, 22 Aug 2019 01:09:00 +1000 Message-Id: <9754e5803feae88a4cfbc507b9da83c0b502e901.1566397711.git.tony.nguyen.git@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 Subject: [Qemu-devel] [PATCH v8 06/21] hw/intc/armv7m_nic: Access MemoryRegion with MemOp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Nguyen , Peter Maydell , Tony Nguyen , Richard Henderson , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The memory_region_dispatch_{read|write} operand "unsigned size" is being converted into a "MemOp op". Convert interfaces by using no-op size_memop. After all interfaces are converted, size_memop will be implemented and the memory_region_dispatch_{read|write} operand "unsigned size" will be converted into a "MemOp op". As size_memop is a no-op, this patch does not change any behaviour. Signed-off-by: Tony Nguyen Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/intc/armv7m_nvic.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c index 62ab8b7273..7220940133 100644 --- a/hw/intc/armv7m_nvic.c +++ b/hw/intc/armv7m_nvic.c @@ -21,6 +21,7 @@ #include "hw/qdev-properties.h" #include "target/arm/cpu.h" #include "exec/exec-all.h" +#include "exec/memop.h" #include "qemu/log.h" #include "qemu/module.h" #include "trace.h" @@ -2348,7 +2349,8 @@ static MemTxResult nvic_sysreg_ns_write(void *opaque, hwaddr addr, if (attrs.secure) { /* S accesses to the alias act like NS accesses to the real region */ attrs.secure = 0; - return memory_region_dispatch_write(mr, addr, value, size, attrs); + return memory_region_dispatch_write(mr, addr, value, size_memop(size), + attrs); } else { /* NS attrs are RAZ/WI for privileged, and BusFault for user */ if (attrs.user) { @@ -2367,7 +2369,8 @@ static MemTxResult nvic_sysreg_ns_read(void *opaque, hwaddr addr, if (attrs.secure) { /* S accesses to the alias act like NS accesses to the real region */ attrs.secure = 0; - return memory_region_dispatch_read(mr, addr, data, size, attrs); + return memory_region_dispatch_read(mr, addr, data, size_memop(size), + attrs); } else { /* NS attrs are RAZ/WI for privileged, and BusFault for user */ if (attrs.user) { @@ -2393,7 +2396,8 @@ static MemTxResult nvic_systick_write(void *opaque, hwaddr addr, /* Direct the access to the correct systick */ mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->systick[attrs.secure]), 0); - return memory_region_dispatch_write(mr, addr, value, size, attrs); + return memory_region_dispatch_write(mr, addr, value, size_memop(size), + attrs); } static MemTxResult nvic_systick_read(void *opaque, hwaddr addr, @@ -2405,7 +2409,7 @@ static MemTxResult nvic_systick_read(void *opaque, hwaddr addr, /* Direct the access to the correct systick */ mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->systick[attrs.secure]), 0); - return memory_region_dispatch_read(mr, addr, data, size, attrs); + return memory_region_dispatch_read(mr, addr, data, size_memop(size), attrs); } static const MemoryRegionOps nvic_systick_ops = { -- 2.23.0