Re: [PATCH v3 00/10] accel/tcg: Improve tb_flush usage

[Richard Henderson <richard.henderson@linaro.org>]

On 9/24/25 05:14, Philippe Mathieu-Daudé wrote:
> On 23/9/25 23:54, Richard Henderson wrote:
>> It is too easy to mis-use tb_flush().  For instance, because of
>> the cpu argument, some parts assumed that it needed to call the
>> global flush function for every cpu.  It is easy to forget that
>> the flush is not complete when the call returns: we have merely
>> queued work to the cpu run loop.  So: remove tb_flush and expose
>> only the core as tb_flush__exclusive, to be used only when we
>> are already within an exclusive context.
>>
>> In some cases (gdbstub, alpha, riscv, ppc spapr),
>> we can eliminate the need for tb_flush completely.
>>
>> Changes for v3:
>>    - Rename to tb_flush__exclusive_or_serial; retain the serial
>>      check within, not updating to exclusive only.
>>    - Rename the existing tb_flush to queue_tb_flush; retain the
>>      sequence number check for duplicated flushes.
>>    - Drop EXCP_TB_FLUSH.
> 
> When using my split-accel branch, I had good results with v2.
> 
> I'm getting crashes with v3:

Are you sure you didn't just get lucky with v2?
There's little functional change to v3...

Point me at your branch?  While I can't test HVF, I can double-check at how you integrated 
the flush.


r~