Re: [SPAM] [PATCH v1 07/13] hw/arm/aspeed: Split Tiogapass machine into a separate source file for cleanup

["Cédric Le Goater" <clg@kaod.org>]

On 10/23/25 12:01, Jamin Lin wrote:
> This commit moves the Tiogapass BMC machine implementation out of
> aspeed.c into a new dedicated file aspeed_ast2500_tiogapass.c.
> 
> To support splitting Tiogapass into a dedicated source file,
> a new TIOGAPASS_BMC_HW_STRAP1 macro is added as a copy of
> AST2500_EVB_HW_STRAP1.
> 
> The change follows the ongoing effort to modularize Aspeed platform
> support by splitting each machine definition into its own source file.
> This makes aspeed.c cleaner, easier to maintain, and simplifies
> future feature additions or refactoring for individual machines.
> 
> Key updates include:
> - Removed tiogapass_bmc_i2c_init() and its FRU data from aspeed.c
> and aspeed_eeprom.c.
> - Removed Tiogapass type registration from aspeed_machine_types[].
> - Added new source file aspeed_ast2500_tiogapass.c to meson.build.
> - Removed unused Tiogapass FRUID declarations from aspeed_eeprom.h.
> 
> No functional changes.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   hw/arm/aspeed_eeprom.h            |  4 --
>   hw/arm/aspeed.c                   | 35 ------------
>   hw/arm/aspeed_ast2500_tiogapass.c | 89 +++++++++++++++++++++++++++++++
>   hw/arm/aspeed_eeprom.c            | 22 --------
>   hw/arm/meson.build                |  1 +
>   5 files changed, 90 insertions(+), 61 deletions(-)
>   create mode 100644 hw/arm/aspeed_ast2500_tiogapass.c
> 


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.