qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] build-sys: put glib_cflags in QEMU_CFLAGS
Date: Mon, 26 Sep 2016 09:11:01 +0200	[thread overview]
Message-ID: <978346da-fdbe-945c-5cfc-1cc7cd9c6d8e@redhat.com> (raw)
In-Reply-To: <20160925205748.6280-2-marcandre.lureau@redhat.com>



On 25/09/2016 22:57, Marc-André Lureau wrote:
> This way, overriding CFLAGS on make command line keeps glib-cflags
> and doesn't break the build.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index c831600..5412d4f 100755
> --- a/configure
> +++ b/configure
> @@ -2933,7 +2933,7 @@ for i in $glib_modules; do
>      if $pkg_config --atleast-version=$glib_req_ver $i; then
>          glib_cflags=$($pkg_config --cflags $i)
>          glib_libs=$($pkg_config --libs $i)
> -        CFLAGS="$glib_cflags $CFLAGS"
> +        QEMU_CFLAGS="$glib_cflags $QEMU_CFLAGS"
>          LIBS="$glib_libs $LIBS"
>          libs_qga="$glib_libs $libs_qga"
>      else
> 

Queued both, thanks.

Paolo

      reply	other threads:[~2016-09-26  7:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-25 20:57 [Qemu-devel] [PATCH 1/2] build-sys: remove unused GLIB_CFLAGS Marc-André Lureau
2016-09-25 20:57 ` [Qemu-devel] [PATCH 2/2] build-sys: put glib_cflags in QEMU_CFLAGS Marc-André Lureau
2016-09-26  7:11   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=978346da-fdbe-945c-5cfc-1cc7cd9c6d8e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).