From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1boQ5E-0003uS-Iy
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 03:12:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1boQ5C-0000u9-L1
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 03:12:11 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <20160925205748.6280-1-marcandre.lureau@redhat.com>
	<20160925205748.6280-2-marcandre.lureau@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <978346da-fdbe-945c-5cfc-1cc7cd9c6d8e@redhat.com>
Date: Mon, 26 Sep 2016 09:11:01 +0200
MIME-Version: 1.0
In-Reply-To: <20160925205748.6280-2-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/2] build-sys: put glib_cflags in
 QEMU_CFLAGS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org



On 25/09/2016 22:57, Marc-André Lureau wrote:
> This way, overriding CFLAGS on make command line keeps glib-cflags
> and doesn't break the build.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index c831600..5412d4f 100755
> --- a/configure
> +++ b/configure
> @@ -2933,7 +2933,7 @@ for i in $glib_modules; do
>      if $pkg_config --atleast-version=$glib_req_ver $i; then
>          glib_cflags=$($pkg_config --cflags $i)
>          glib_libs=$($pkg_config --libs $i)
> -        CFLAGS="$glib_cflags $CFLAGS"
> +        QEMU_CFLAGS="$glib_cflags $QEMU_CFLAGS"
>          LIBS="$glib_libs $LIBS"
>          libs_qga="$glib_libs $libs_qga"
>      else
> 

Queued both, thanks.

Paolo