* [PATCH] util: Delete a check for IA-64
@ 2023-08-08 15:20 Akihiko Odaki
2023-08-08 15:23 ` Peter Maydell
2023-08-10 10:52 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Akihiko Odaki @ 2023-08-08 15:20 UTC (permalink / raw)
Cc: qemu-devel, Paolo Bonzini, Akihiko Odaki
HOST_IA64 will never be defined since IA-64 host is no longer supported.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
util/oslib-posix.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 760390b31e..f7adb36dfb 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -618,10 +618,7 @@ void *qemu_alloc_stack(size_t *sz)
abort();
}
-#if defined(HOST_IA64)
- /* separate register stack */
- guardpage = ptr + (((*sz - pagesz) / 2) & ~pagesz);
-#elif defined(HOST_HPPA)
+#if defined(HOST_HPPA)
/* stack grows up */
guardpage = ptr + *sz - pagesz;
#else
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] util: Delete a check for IA-64
2023-08-08 15:20 [PATCH] util: Delete a check for IA-64 Akihiko Odaki
@ 2023-08-08 15:23 ` Peter Maydell
2023-08-10 10:52 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-08-08 15:23 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: qemu-devel, Paolo Bonzini
On Tue, 8 Aug 2023 at 16:21, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> HOST_IA64 will never be defined since IA-64 host is no longer supported.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> util/oslib-posix.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 760390b31e..f7adb36dfb 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -618,10 +618,7 @@ void *qemu_alloc_stack(size_t *sz)
> abort();
> }
>
> -#if defined(HOST_IA64)
> - /* separate register stack */
> - guardpage = ptr + (((*sz - pagesz) / 2) & ~pagesz);
> -#elif defined(HOST_HPPA)
> +#if defined(HOST_HPPA)
> /* stack grows up */
> guardpage = ptr + *sz - pagesz;
> #else
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(There's another one in include/exec/user/thunk.h.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] util: Delete a check for IA-64
2023-08-08 15:20 [PATCH] util: Delete a check for IA-64 Akihiko Odaki
2023-08-08 15:23 ` Peter Maydell
@ 2023-08-10 10:52 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-10 10:52 UTC (permalink / raw)
To: Akihiko Odaki; +Cc: qemu-devel, Paolo Bonzini
On 8/8/23 17:20, Akihiko Odaki wrote:
> HOST_IA64 will never be defined since IA-64 host is no longer supported.
If you send a v2 removing the similar definition in
include/exec/user/thunk.h, please mention this is since commit
b1cef6d02f("Drop remaining bits of ia64 host support").
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> util/oslib-posix.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-10 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 15:20 [PATCH] util: Delete a check for IA-64 Akihiko Odaki
2023-08-08 15:23 ` Peter Maydell
2023-08-10 10:52 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).