From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] target/arm: Do not use gen_mte_checkN in trans_STGP
Date: Thu, 3 Aug 2023 07:42:19 -0700 [thread overview]
Message-ID: <97884811-7b78-286e-fcec-248430a877b1@linaro.org> (raw)
In-Reply-To: <CAFEAcA_wYBSiBRy6HQaRh7k=UFrnQ=EwSQQ2e=7PJUzfyVp-ng@mail.gmail.com>
On 8/3/23 06:10, Peter Maydell wrote:
> On Thu, 27 Jul 2023 at 17:33, Richard Henderson
>> - mop = MO_128;
>> - if (s->align_mem) {
>> - mop |= MO_ALIGN_8;
>> - }
>> - mop = finalize_memop_pair(s, mop);
>> + mop = MO_128 | MO_ALIGN | MO_ATOM_IFALIGN_PAIR;
>
> So here we're implicitly assuming TAG_GRANULE is 16 and
> then relying on the codegen for a MO_128 | MO_ALIGN
> operation to give us the alignment fault if the guest
> address isn't aligned to the tag granule, right ?
Yes.
>
> Previously we also put s->be_data into the MemOp
> (via finalize_memop_pair() calling finalize_memop_atom()).
> Don't we still need to do that ?
Whoops, yes.
r~
next prev parent reply other threads:[~2023-08-03 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 16:26 [PATCH] target/arm: Do not use gen_mte_checkN in trans_STGP Richard Henderson
2023-07-28 13:17 ` Peter Maydell
2023-07-28 13:30 ` Richard Henderson
2023-08-03 13:10 ` Peter Maydell
2023-08-03 14:42 ` Richard Henderson [this message]
2023-09-01 12:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97884811-7b78-286e-fcec-248430a877b1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).