From: James Bottomley <jejb@linux.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH v3 0/2] tpm: add mssim backend
Date: Mon, 19 Dec 2022 10:21:45 -0500 [thread overview]
Message-ID: <9798dca3264b0df2af7cd40d845d9f932af5f5db.camel@linux.ibm.com> (raw)
In-Reply-To: <bf7aa576-b4b0-5054-915e-7933bf1abac8@linux.ibm.com>
On Mon, 2022-12-19 at 10:16 -0500, Stefan Berger wrote:
>
>
> On 12/19/22 08:13, James Bottomley wrote:
> > From: James Bottomley <James.Bottomley@HansenPartnership.com>
> >
> > The requested feedback was to convert the tpmdev handler to being
> > json
> > based, which requires rethreading all the backends. The good news
> > is
> > this reduced quite a bit of code (especially as I converted it to
> > error_fatal handling as well, which removes the return status
> > threading). The bad news is I can't test any of the conversions.
> > swtpm still isn't building on opensuse and, apparently, passthrough
> > doesn't like my native TPM because it doesn't allow cancellation.
>
> For passthrough you can use /dev/null in place of the cancel file.
> Libvirt does that also:
>
> https://github.com/stefanberger/libvirt-tpm/blob/master/src/util/virtpm.c#L88
OK, so passthrough works with the visitor conversion. If /dev/null is
the default for no cancel path, the backend shouldn't really beat the
end user up about not specifying it if it can't find the cancel path
for the chosen host TPM.
James
prev parent reply other threads:[~2022-12-19 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 13:13 [PATCH v3 0/2] tpm: add mssim backend James Bottomley
2022-12-19 13:13 ` [PATCH v3 1/2] tpm: convert tpmdev options processing to new visitor format James Bottomley
2022-12-21 16:32 ` Daniel P. Berrangé
2022-12-21 20:31 ` James Bottomley
2022-12-19 13:13 ` [PATCH v3 2/2] tpm: add backend for mssim James Bottomley
2022-12-19 13:51 ` [PATCH v3 0/2] tpm: add mssim backend Stefan Berger
2022-12-19 13:55 ` James Bottomley
2022-12-19 14:15 ` Stefan Berger
2022-12-19 14:17 ` James Bottomley
2022-12-19 15:16 ` Stefan Berger
2022-12-19 15:21 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9798dca3264b0df2af7cd40d845d9f932af5f5db.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).