From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, jasowang@redhat.com, dmitry@daynix.com,
dgibson@redhat.com, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.11] hw/net/vmxnet3: Fix code to work on big endian hosts, too
Date: Mon, 13 Nov 2017 21:23:22 +0100 [thread overview]
Message-ID: <97a152d7-e09d-1d0f-72ab-20d270d7a06f@redhat.com> (raw)
In-Reply-To: <151059294250.396.15891441677342276715@bafd83ae6430>
On 13.11.2017 18:09, no-reply@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
[...]
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: hw/net/vmxnet3: Fix code to work on big endian hosts, too...
> ERROR: spaces required around that ':' (ctx:VxV)
> #202: FILE: hw/net/vmxnet3.h:232:
> + u32 msscof:14; /* MSS, checksum offset, flags */
FWIW, these are definitely false warnings: If I change the patch to use
spaces around ":" everywhere in the bitfields, checkpatch complains
instead that the spaces should be removed!
Thomas
next parent reply other threads:[~2017-11-13 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <151059294250.396.15891441677342276715@bafd83ae6430>
2017-11-13 20:23 ` Thomas Huth [this message]
2017-11-13 16:57 [Qemu-devel] [PATCH for-2.11] hw/net/vmxnet3: Fix code to work on big endian hosts, too Thomas Huth
2017-11-13 17:00 ` Dmitry Fleytman
2017-11-13 22:38 ` Philippe Mathieu-Daudé
2017-11-14 8:21 ` Thomas Huth
2017-11-14 11:37 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a152d7-e09d-1d0f-72ab-20d270d7a06f@redhat.com \
--to=thuth@redhat.com \
--cc=dgibson@redhat.com \
--cc=dmitry@daynix.com \
--cc=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).