From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78EFC33CA2 for ; Fri, 10 Jan 2020 08:07:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B66A32072E for ; Fri, 10 Jan 2020 08:07:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B66A32072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ippKj-0000XR-OP for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 03:07:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56399) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ippK7-0008RB-60 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 03:07:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ippK5-0005eA-I9 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 03:07:14 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:57420 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ippK5-0005Ka-3s; Fri, 10 Jan 2020 03:07:13 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 80DAB129B473B15A1F68; Fri, 10 Jan 2020 16:07:08 +0800 (CST) Received: from [10.184.39.213] (10.184.39.213) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 16:06:59 +0800 Subject: Re: [PATCH] vl: Don't mismatch g_strsplit()/g_free() To: Laurent Vivier , References: <20200110031618.23332-1-pannengyuan@huawei.com> <49907b09-2c11-1e95-9aa2-6b9cb0abf6cb@vivier.eu> From: Pan Nengyuan Message-ID: <97aff10c-d51f-3db2-3c59-183793dc6e3f@huawei.com> Date: Fri, 10 Jan 2020 16:06:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <49907b09-2c11-1e95-9aa2-6b9cb0abf6cb@vivier.eu> Content-Type: text/plain; charset="utf-8" X-Originating-IP: [10.184.39.213] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org, Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/10/2020 3:59 PM, Laurent Vivier wrote: > Le 10/01/2020 =C3=A0 04:16, pannengyuan@huawei.com a =C3=A9crit=C2=A0: >> From: Pan Nengyuan >> >> It's a mismatch between g_strsplit and g_free, it will cause a memory = leak as follow: >> >> [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help >> Accelerators supported in QEMU binary: >> tcg >> kvm >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =3D=3D1207900=3D=3DERROR: LeakSanitizer: detected memory leaks >> >> Direct leak of 8 byte(s) in 2 object(s) allocated from: >> #0 0xfffd700231cb in __interceptor_malloc (/lib64/libasan.so.4+0xd= 31cb) >> #1 0xfffd6ec57163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163) >> #2 0xfffd6ec724d7 in g_strndup (/lib64/libglib-2.0.so.0+0x724d7) >> #3 0xfffd6ec73d3f in g_strsplit (/lib64/libglib-2.0.so.0+0x73d3f) >> #4 0xaaab66be5077 in main /mnt/sdc/qemu-master/qemu-4.2.0-rc0/vl.c= :3517 >> #5 0xfffd6e140b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f) >> #6 0xaaab66bf0f53 (./build/aarch64-softmmu/qemu-system-aarch64+0x= 8a0f53) >> >> Direct leak of 2 byte(s) in 2 object(s) allocated from: >> #0 0xfffd700231cb in __interceptor_malloc (/lib64/libasan.so.4+0xd= 31cb) >> #1 0xfffd6ec57163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163) >> #2 0xfffd6ec7243b in g_strdup (/lib64/libglib-2.0.so.0+0x7243b) >> #3 0xfffd6ec73e6f in g_strsplit (/lib64/libglib-2.0.so.0+0x73e6f) >> #4 0xaaab66be5077 in main /mnt/sdc/qemu-master/qemu-4.2.0-rc0/vl.c= :3517 >> #5 0xfffd6e140b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f) >> #6 0xaaab66bf0f53 (./build/aarch64-softmmu/qemu-system-aarch64+0x= 8a0f53) >> >> Reported-by: Euler Robot >> Signed-off-by: Pan Nengyuan >> --- >> vl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/vl.c b/vl.c >> index 86474a55c9..2fa5cb3b9a 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -3476,7 +3476,7 @@ int main(int argc, char **argv, char **envp) >> gchar **optname =3D g_strsplit(typename, >> ACCEL_CLASS_= SUFFIX, 0); >> printf("%s\n", optname[0]); >> - g_free(optname); >> + g_strfreev(optname); >> } >> g_free(typename); >> } >> >=20 > It is correct but could you try to cover all the cases? >=20 > For instance, there is another one in qga/main.c:split_list(). Ok, I will try to do it. Thanks. >=20 > Thanks, > Laurent >=20