From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Warner Losh <imp@bsdimp.com>
Subject: Re: [PATCH v2 08/10] target/i386: implement 32-bit SYSCALL for linux-user
Date: Tue, 20 Jun 2023 18:10:23 +0200 [thread overview]
Message-ID: <97cf0a1f-86c6-6bd3-5643-4982a5db03bb@linaro.org> (raw)
In-Reply-To: <20230620151634.21053-9-pbonzini@redhat.com>
On 6/20/23 17:16, Paolo Bonzini wrote:
> @@ -211,6 +211,9 @@ void cpu_loop(CPUX86State *env)
>
> switch(trapnr) {
> case 0x80:
> +#ifdef TARGET_ABI32
> + case EXCP_SYSCALL:
> +#endif
> /* linux syscall from int $0x80 */
ABI32 includes x32.
I think you want TARGET_I386.
> +#if defined CONFIG_SOFTMMU || defined CONFIG_LINUX_USER
> +#define TCG_EXT2_NOBSD_FEATURES CPUID_EXT2_SYSCALL
> +#else
> +#define TCG_EXT2_NOBSD_FEATURES 0
> +#endif
Missing TARGET_I386 test per above.
Better named TCG_EXT2_USERONLY_FEATURES.
Warner, if I'm reading freebsd-src correctly, sys/x86 (aka 32-bit) does not use
sysenter/sysret? I only see that under sys/amd64 (where fast_syscall32 is a cya nop).
r~
next prev parent reply other threads:[~2023-06-20 16:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:16 [PATCH v2 00/10] target/i386: add a few simple features Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 01/10] target/i386: fix INVD vmexit Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 02/10] target/i386: TCG supports 3DNow! prefetch(w) Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 03/10] target/i386: TCG supports RDSEED Paolo Bonzini
2023-06-20 16:24 ` Richard Henderson
2023-06-21 5:46 ` Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 04/10] target/i386: TCG supports XSAVEERPTR Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 05/10] target/i386: TCG supports WBNOINVD Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 06/10] target/i386: Intel only supports SYSCALL in long mode Paolo Bonzini
2023-06-20 15:57 ` Richard Henderson
2023-06-20 15:16 ` [PATCH v2 07/10] target/i386: sysret and sysexit are privileged Paolo Bonzini
2023-06-20 15:58 ` Richard Henderson
2023-06-20 15:16 ` [PATCH v2 08/10] target/i386: implement 32-bit SYSCALL for linux-user Paolo Bonzini
2023-06-20 16:10 ` Richard Henderson [this message]
2023-06-20 15:16 ` [PATCH v2 09/10] target/i386: implement 32-bit SYSENTER " Paolo Bonzini
2023-06-20 16:22 ` Richard Henderson
2023-06-20 16:27 ` Paolo Bonzini
2023-06-20 15:16 ` [PATCH v2 10/10] target/i386: implement RDPID in TCG Paolo Bonzini
2023-06-20 16:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97cf0a1f-86c6-6bd3-5643-4982a5db03bb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=imp@bsdimp.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).