From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, "Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [RFC PATCH] gdbstub: attempt to split gdb into 32/64 bit targets [!WORKING PLZ HELP]
Date: Thu, 2 Mar 2023 15:21:58 -0800 [thread overview]
Message-ID: <97d3a552-2bac-6cc8-345c-0b5a50a772e6@linaro.org> (raw)
In-Reply-To: <20230302192546.2617633-1-alex.bennee@linaro.org>
On 3/2/23 09:25, Alex Bennée wrote:
> -# These have to built to the target ABI
> -specific_ss.add(files('syscalls.c'))
> +# These have to built to the target ABI but are otherwise target
> +# independent
> +gdb32_ss = ss.source_set()
> +gdb64_ss = ss.source_set()
> +
> +gdb32_ss.add(files('syscalls.c'))
> +gdb64_ss.add(files('syscalls.c'))
> +
> +gdb32_ss = gdb32_ss.apply(config_host, strict: false)
> +gdb64_ss = gdb64_ss.apply(config_host, strict: false)
You don't need the source sets.
> +libgdb32 = static_library('gdb32', gdb32_ss.sources(),
> + name_suffix: 'fa',
> + c_args: ['-DTARGET_LONG_BITS=32'])
> +libgdb64 = static_library('gdb64', gdb64_ss.sources(),
> + name_suffix: 'fa',
> + c_args: ['-DTARGET_LONG_BITS=64'])
> +
> +gdb32 = declare_dependency(link_whole: libgdb32)
> +gdb64 = declare_dependency(link_whole: libgdb64)
It appears to work with "link_with:".
Both comments apply here and to your gdb_user/gdb_softmmu libraries.
r~
next prev parent reply other threads:[~2023-03-02 23:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 19:25 [RFC PATCH] gdbstub: attempt to split gdb into 32/64 bit targets [!WORKING PLZ HELP] Alex Bennée
2023-03-02 23:21 ` Richard Henderson [this message]
2023-03-02 23:56 ` Richard Henderson
2023-03-03 0:38 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97d3a552-2bac-6cc8-345c-0b5a50a772e6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).