qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Burton <mburton@qti.qualcomm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Peter Xu" <peterx@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] memory: Do not print MR priority in flatview HMP output
Date: Wed, 28 Dec 2022 19:51:28 +0100	[thread overview]
Message-ID: <97d4e782-c10c-9e3b-28d4-122c4d524608@linaro.org> (raw)
In-Reply-To: <SN4PR0201MB3613EBE63C845BB5BA4DF6018FF29@SN4PR0201MB3613.namprd02.prod.outlook.com>

On 28/12/22 17:26, Mark Burton wrote:
> Is there any chance between 7.1 and 7.2 ‘something’ happened to make it 
> so that Qemu ‘cares more’ about e.g. when memory regions are added/removed?
> 
> I seem to get an abort because a memory region has not been completely 
> setup in 7.2 (while it is being flattened actually) - In 7.1 that never 
> seemed to happen….?

I couldn't find any relevant changes in softmmu/. Maybe TCG related?

$ git diff --stat v7.1.0..v7.2.0 -- softmmu/
  softmmu/cpus.c         | 18 +++++++++++++-----
  softmmu/device_tree.c  | 58 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  softmmu/dirtylimit.c   |  4 ++--
  softmmu/main.c         | 10 +++++-----
  softmmu/memory.c       | 72 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  softmmu/physmem.c      | 36 ++++++++++++++++++------------------
  softmmu/qemu-seccomp.c | 13 +++++++++++++
  softmmu/qtest.c        | 12 +++++++++---
  softmmu/runstate.c     | 11 ++++++++---
  softmmu/vl.c           | 85 
+++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------
  10 files changed, 249 insertions(+), 70 deletions(-)

$ git diff --stat v7.1.0..v7.2.0 -- accel/tcg/
  accel/tcg/cpu-exec-common.c     |    2 +-
  accel/tcg/cpu-exec.c            |  229 +++++++++++++++------------
  accel/tcg/cputlb.c              |  350 
+++++++++++++++++++++---------------------
  accel/tcg/internal.h            |  101 ++++++++++++
  accel/tcg/meson.build           |    1 +
  accel/tcg/plugin-gen.c          |   22 +--
  accel/tcg/tb-hash.h             |    1 +
  accel/tcg/tb-jmp-cache.h        |   65 ++++++++
  accel/tcg/tb-maint.c            |  704 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  accel/tcg/tcg-accel-ops-mttcg.c |    5 +-
  accel/tcg/tcg-accel-ops-rr.c    |    9 +-
  accel/tcg/tcg-accel-ops.c       |   98 ++++++++++++
  accel/tcg/tcg-all.c             |   17 +++
  accel/tcg/translate-all.c       | 1249 
+++++++++++++++++++---------------------------------------------------------------------------------------------------------------------------------
  accel/tcg/translator.c          |  138 ++++++++++++-----
  accel/tcg/user-exec.c           |   59 ++++++-
  16 files changed, 1628 insertions(+), 1422 deletions(-)

I'll have a look at

   $ git log -p v7.1.0..v7.2.0 accel/tcg/

> (Putting it all async work seems ‘excessive’ but maybe it’s needed now?)
> 
> 
> Cheers
> Mark


  reply	other threads:[~2022-12-28 18:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 13:04 [PATCH] memory: Do not print MR priority in flatview HMP output Philippe Mathieu-Daudé
2022-12-28 16:26 ` Mark Burton
2022-12-28 18:51   ` Philippe Mathieu-Daudé [this message]
2023-01-03 21:48 ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97d4e782-c10c-9e3b-28d4-122c4d524608@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=david@redhat.com \
    --cc=mburton@qti.qualcomm.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).