* [PATCH] s390x/cpu_model: disallow unpack for --only-migratable
@ 2021-01-25 12:53 Christian Borntraeger
2021-01-25 12:57 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2021-01-25 12:53 UTC (permalink / raw)
To: Cornelia Huck
Cc: Thomas Huth, Daniel P . Berrangé, Janosch Frank,
David Hildenbrand, qemu-devel, Dr . David Alan Gilbert,
Halil Pasic, Christian Borntraeger, qemu-s390x, David Gibson,
Richard Henderson
secure execution (aka protected virtualization) guests cannot be
migrated at the moment. Disallow the unpack facility if the user
specifies --only-migratable.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
target/s390x/cpu_models.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 35179f9dc7ba..0fa082ae2546 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -26,6 +26,7 @@
#include "qapi/qmp/qdict.h"
#ifndef CONFIG_USER_ONLY
#include "sysemu/arch_init.h"
+#include "sysemu/sysemu.h"
#include "hw/pci/pci.h"
#endif
#include "qapi/qapi-commands-machine-target.h"
@@ -878,6 +879,11 @@ static void check_compatibility(const S390CPUModel *max_model,
return;
}
+ if (only_migratable && test_bit(S390_FEAT_UNPACK, model->features)) {
+ error_setg(errp, "The unpack facility is not compatible with "
+ "the --only-migratable option");
+ }
+
/* detect the missing features to properly report them */
bitmap_andnot(missing, model->features, max_model->features, S390_FEAT_MAX);
if (bitmap_empty(missing, S390_FEAT_MAX)) {
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable
2021-01-25 12:53 [PATCH] s390x/cpu_model: disallow unpack for --only-migratable Christian Borntraeger
@ 2021-01-25 12:57 ` David Hildenbrand
2021-01-25 12:59 ` Christian Borntraeger
0 siblings, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2021-01-25 12:57 UTC (permalink / raw)
To: Christian Borntraeger, Cornelia Huck
Cc: Thomas Huth, Daniel P . Berrangé, Janosch Frank, qemu-devel,
Dr . David Alan Gilbert, Halil Pasic, qemu-s390x, David Gibson,
Richard Henderson
On 25.01.21 13:53, Christian Borntraeger wrote:
> secure execution (aka protected virtualization) guests cannot be
> migrated at the moment. Disallow the unpack facility if the user
> specifies --only-migratable.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> target/s390x/cpu_models.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 35179f9dc7ba..0fa082ae2546 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -26,6 +26,7 @@
> #include "qapi/qmp/qdict.h"
> #ifndef CONFIG_USER_ONLY
> #include "sysemu/arch_init.h"
> +#include "sysemu/sysemu.h"
> #include "hw/pci/pci.h"
> #endif
> #include "qapi/qapi-commands-machine-target.h"
> @@ -878,6 +879,11 @@ static void check_compatibility(const S390CPUModel *max_model,
> return;
> }
>
> + if (only_migratable && test_bit(S390_FEAT_UNPACK, model->features)) {
> + error_setg(errp, "The unpack facility is not compatible with "
> + "the --only-migratable option");
return; ?
This implies that a VM with "-cpu host" might not start anymore, right?
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable
2021-01-25 12:57 ` David Hildenbrand
@ 2021-01-25 12:59 ` Christian Borntraeger
2021-01-25 13:04 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2021-01-25 12:59 UTC (permalink / raw)
To: David Hildenbrand, Cornelia Huck
Cc: Thomas Huth, Daniel P . Berrangé, Janosch Frank, qemu-devel,
Dr . David Alan Gilbert, Halil Pasic, qemu-s390x, David Gibson,
Richard Henderson
On 25.01.21 13:57, David Hildenbrand wrote:
> On 25.01.21 13:53, Christian Borntraeger wrote:
>> secure execution (aka protected virtualization) guests cannot be
>> migrated at the moment. Disallow the unpack facility if the user
>> specifies --only-migratable.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> target/s390x/cpu_models.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
>> index 35179f9dc7ba..0fa082ae2546 100644
>> --- a/target/s390x/cpu_models.c
>> +++ b/target/s390x/cpu_models.c
>> @@ -26,6 +26,7 @@
>> #include "qapi/qmp/qdict.h"
>> #ifndef CONFIG_USER_ONLY
>> #include "sysemu/arch_init.h"
>> +#include "sysemu/sysemu.h"
>> #include "hw/pci/pci.h"
>> #endif
>> #include "qapi/qapi-commands-machine-target.h"
>> @@ -878,6 +879,11 @@ static void check_compatibility(const S390CPUModel *max_model,
>> return;
>> }
>>
>> + if (only_migratable && test_bit(S390_FEAT_UNPACK, model->features)) {
>> + error_setg(errp, "The unpack facility is not compatible with "
>> + "the --only-migratable option");
>
> return; ?
of course.
>
>
> This implies that a VM with "-cpu host" might not start anymore, right?
Only if --only-migratable is set.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable
2021-01-25 12:59 ` Christian Borntraeger
@ 2021-01-25 13:04 ` David Hildenbrand
0 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2021-01-25 13:04 UTC (permalink / raw)
To: Christian Borntraeger, Cornelia Huck
Cc: Thomas Huth, Daniel P . Berrangé, Janosch Frank, qemu-devel,
Dr . David Alan Gilbert, Halil Pasic, qemu-s390x, David Gibson,
Richard Henderson
On 25.01.21 13:59, Christian Borntraeger wrote:
>
>
> On 25.01.21 13:57, David Hildenbrand wrote:
>> On 25.01.21 13:53, Christian Borntraeger wrote:
>>> secure execution (aka protected virtualization) guests cannot be
>>> migrated at the moment. Disallow the unpack facility if the user
>>> specifies --only-migratable.
>>>
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> target/s390x/cpu_models.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
>>> index 35179f9dc7ba..0fa082ae2546 100644
>>> --- a/target/s390x/cpu_models.c
>>> +++ b/target/s390x/cpu_models.c
>>> @@ -26,6 +26,7 @@
>>> #include "qapi/qmp/qdict.h"
>>> #ifndef CONFIG_USER_ONLY
>>> #include "sysemu/arch_init.h"
>>> +#include "sysemu/sysemu.h"
>>> #include "hw/pci/pci.h"
>>> #endif
>>> #include "qapi/qapi-commands-machine-target.h"
>>> @@ -878,6 +879,11 @@ static void check_compatibility(const S390CPUModel *max_model,
>>> return;
>>> }
>>>
>>> + if (only_migratable && test_bit(S390_FEAT_UNPACK, model->features)) {
>>> + error_setg(errp, "The unpack facility is not compatible with "
>>> + "the --only-migratable option");
>>
>> return; ?
>
> of course.
>
>>
>>
>> This implies that a VM with "-cpu host" might not start anymore, right?
>
> Only if --only-migratable is set.
>
Right, that's what I meant
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-25 13:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-25 12:53 [PATCH] s390x/cpu_model: disallow unpack for --only-migratable Christian Borntraeger
2021-01-25 12:57 ` David Hildenbrand
2021-01-25 12:59 ` Christian Borntraeger
2021-01-25 13:04 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).