From: Thomas Huth <thuth@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mauro Matteo Cascella" <mcascell@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Bandan Das" <bsd@redhat.com>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Jon Maloy" <jmaloy@redhat.com>, "Siqi Chen" <coc.cyqh@gmail.com>,
"Michael Tokarev" <mjt@tls.msk.ru>, "Fam Zheng" <fam@euphon.net>,
"open list:Block I/O path" <qemu-block@nongnu.org>
Subject: Re: [PATCH v9 7/8] memory: abort on re-entrancy in debug builds
Date: Thu, 27 Apr 2023 18:05:52 +0200 [thread overview]
Message-ID: <97eba78f-59d2-5eaa-50ec-7ddbd9fa9f3a@redhat.com> (raw)
In-Reply-To: <20230427144444.dnjazwxpcrmrce7e@mozz.bu.edu>
On 27/04/2023 16.44, Alexander Bulekov wrote:
> On 230426 1219, Alexander Bulekov wrote:
>> This is useful for using unit-tests/fuzzing to detect bugs introduced by
>> the re-entrancy guard mechanism into devices that are intentionally
>> re-entrant.
>>
>> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> ---
>
> This doesn't actually do anything right now. Doesn't look like DEBUG is
> defined with --enable-debug
Ah, I thought you'd enable it with --extra-cflags=-DDEBUG or so
> Any suggestion for how to make re-entrancy louder/fatal on
> debug/developer builds? Maybe we can just replace the trace event with
> an unconditional log-message?
I'm not sure whether I'd go for a completely uncondition log message, but
maybe qemu_log_mask(LOG_GUEST_ERROR, ...) is ok?
Thomas
next prev parent reply other threads:[~2023-04-27 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 16:19 [PATCH v9 0/8] memory: prevent dma-reentracy issues Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 1/8] " Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 2/8] async: Add an optional reentrancy guard to the BH API Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 3/8] checkpatch: add qemu_bh_new/aio_bh_new checks Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 4/8] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 5/8] lsi53c895a: disable reentrancy detection for script RAM Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 6/8] bcm2835_property: disable reentrancy detection for iomem Alexander Bulekov
2023-04-26 16:19 ` [PATCH v9 7/8] memory: abort on re-entrancy in debug builds Alexander Bulekov
2023-04-27 14:44 ` Alexander Bulekov
2023-04-27 16:05 ` Thomas Huth [this message]
2023-04-26 16:19 ` [PATCH v9 8/8] raven: disable reentrancy detection for iomem Alexander Bulekov
2023-04-27 6:36 ` Thomas Huth
2023-04-27 13:04 ` [PATCH v9 0/8] memory: prevent dma-reentracy issues Thomas Huth
2023-04-27 13:45 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97eba78f-59d2-5eaa-50ec-7ddbd9fa9f3a@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=bsd@redhat.com \
--cc=coc.cyqh@gmail.com \
--cc=darren.kenny@oracle.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=jmaloy@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mcascell@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).