From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] QAPI file renames
Date: Mon, 12 Feb 2018 10:13:02 -0600 [thread overview]
Message-ID: <97ed0d16-0c25-ed1d-9660-8bf4afad7e52@redhat.com> (raw)
In-Reply-To: <87h8qnj1wl.fsf@dusky.pond.sub.org>
On 02/11/2018 03:44 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
>
>> This has been mentioned on list before as a possible improvement,
>> so I went ahead and did some renames to figure out how it would
>> look. Patch 1 is something I hit on the way while debugging
>> patch 2 and 3; patch 2 is rather non-controversial, and patch 3
>> may or may not be worth doing (but if we do it, it is going
>> to cause a lot of rebase churn to anyone editing files in the
>> meantime, although git rename detection will probably get things
>> right more often than not).
>
> Conflicts with my "[PATCH v2 00/29] Modularize generated QAPI code".
> Your series is much smaller. Would you mind rebasing it?
Of course, yours definitely goes in first. And let me know if I need to
take care of some pull requests, based on your current situation.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-02-12 16:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 0:40 [Qemu-devel] [PATCH 0/3] QAPI file renames Eric Blake
2018-02-11 0:40 ` [Qemu-devel] [PATCH 1/3] qapi: Pass '-u' when doing non-silent diff Eric Blake
2018-02-11 4:11 ` Philippe Mathieu-Daudé
2018-02-11 12:04 ` Markus Armbruster
2018-02-12 16:10 ` Eric Blake
2018-02-11 0:40 ` [Qemu-devel] [PATCH 2/3] qapi: Rename QMP and QGA schema files Eric Blake
2018-02-11 9:49 ` Markus Armbruster
2018-02-12 16:12 ` Eric Blake
2018-02-15 19:03 ` Michael Roth
2018-02-11 0:40 ` [Qemu-devel] [PATCH 3/3] qapi: Rename .json to .qapi Eric Blake
2018-02-12 9:52 ` Daniel P. Berrangé
2018-02-12 10:17 ` Marc-André Lureau
2018-02-23 17:15 ` Markus Armbruster
2018-02-11 9:44 ` [Qemu-devel] [PATCH 0/3] QAPI file renames Markus Armbruster
2018-02-12 16:13 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ed0d16-0c25-ed1d-9660-8bf4afad7e52@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).