From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 3/5] tests: Restore check-qdict unit test
Date: Wed, 10 Oct 2018 11:43:05 -0500 [thread overview]
Message-ID: <97edaf90-6e1b-92b0-9bcf-3e894328512e@redhat.com> (raw)
In-Reply-To: <20181010061113.6057-4-armbru@redhat.com>
On 10/10/18 1:11 AM, Markus Armbruster wrote:
> Commit 0bcc8e5bd8d accidentally dropped check-qdict from the list of
> unit tests (again, see commit 4429532b48a). Put it back, and fix up
> the test.
Since this seems to be a recurring problem...
> +++ b/tests/Makefile.include
> @@ -40,7 +40,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
>
> check-unit-y = tests/check-qdict$(EXESUF)
How about a followup patch that does:
- check-unit-y = tests/check-qdict$(EXESUF)
+ check-unit-y =
+ check-unit-y += tests/check-qdict$(EXESUF)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-10-10 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 6:11 [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2018-10-10 Markus Armbruster
2018-10-10 6:11 ` [Qemu-devel] [PULL 1/5] tests/check-qjson: fix a leak Markus Armbruster
2018-10-10 6:11 ` [Qemu-devel] [PULL 2/5] qapi/misc.json: Remove superfluous words in CpuModelExpansionType Markus Armbruster
2018-10-10 6:11 ` [Qemu-devel] [PULL 3/5] tests: Restore check-qdict unit test Markus Armbruster
2018-10-10 16:43 ` Eric Blake [this message]
2018-10-10 16:57 ` Philippe Mathieu-Daudé
2018-10-10 6:11 ` [Qemu-devel] [PULL 4/5] libqtest: Inline g_assert_no_errno() Markus Armbruster
2018-10-10 6:11 ` [Qemu-devel] [PULL 5/5] ivshmem: Fix unplug of device "ivshmem-plain" Markus Armbruster
2018-10-11 11:57 ` [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2018-10-10 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97edaf90-6e1b-92b0-9bcf-3e894328512e@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).