From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/3] Move dbus-display1 out of ui
Date: Sat, 16 Dec 2023 17:57:52 +0100 [thread overview]
Message-ID: <97f0a23c-dc29-4687-af8d-388d7a63947a@linaro.org> (raw)
In-Reply-To: <20231216-dbus-v3-1-b4bcbed7374a@daynix.com>
On 16/12/23 08:53, Akihiko Odaki wrote:
> Despite its name, dbus-display1 does not only provide DBus interfaces
> for the display but also for the audio.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> MAINTAINERS | 1 +
> meson.build | 21 +++++++++++++++++++++
> ui/dbus.h | 2 +-
> audio/dbusaudio.c | 2 +-
> tests/qtest/dbus-display-test.c | 2 +-
> ui/dbus-display1.xml => dbus-display1.xml | 0
What about moving it to backends/ instead? Also could be renamed.
"ui" means User Interface. Audio is still one. Suggestions:
ui/dbus-backend, backends/dbus-... ?
> ui/meson.build | 18 ------------------
> 7 files changed, 25 insertions(+), 21 deletions(-)
next prev parent reply other threads:[~2023-12-16 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 7:53 [PATCH v3 0/3] meson: Fixes for dbus modules Akihiko Odaki
2023-12-16 7:53 ` [PATCH v3 1/3] Move dbus-display1 out of ui Akihiko Odaki
2023-12-16 16:57 ` Philippe Mathieu-Daudé [this message]
2023-12-17 6:14 ` Akihiko Odaki
2023-12-16 7:53 ` [PATCH v3 2/3] meson: Add dbus_display1 to util_ss and genh Akihiko Odaki
2023-12-16 7:53 ` [PATCH v3 3/3] audio: Do not include ui/dbus.h Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97f0a23c-dc29-4687-af8d-388d7a63947a@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).