From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, eblake@redhat.com, jsnow@redhat.com,
famz@redhat.com, den@openvz.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch
Date: Tue, 14 Nov 2017 15:58:16 +0100 [thread overview]
Message-ID: <97ffde23-8da4-fc99-85f0-a96d05b9fca6@redhat.com> (raw)
In-Reply-To: <20171023092945.54532-1-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On 2017-10-23 11:29, Vladimir Sementsov-Ogievskiy wrote:
> Snapshot-switch actually changes active state of disk so it should
> reflect on dirty bitmaps. Otherwise next incremental backup using
> these bitmaps will be invalid.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/snapshot.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Thanks, applied to my block tree:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-11-14 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 9:29 [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch Vladimir Sementsov-Ogievskiy
2017-10-27 21:23 ` Eric Blake
2017-11-02 20:55 ` John Snow
2017-11-14 14:58 ` Max Reitz [this message]
2017-11-17 12:30 ` Kevin Wolf
2017-11-17 12:58 ` Denis V. Lunev
2017-11-17 13:42 ` Kevin Wolf
2017-11-17 13:45 ` Denis V. Lunev
2017-11-17 15:01 ` Max Reitz
2017-11-17 18:15 ` John Snow
2017-11-17 18:25 ` Kevin Wolf
2017-11-17 20:40 ` John Snow
2017-11-20 9:51 ` Vladimir Sementsov-Ogievskiy
2017-11-20 12:00 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ffde23-8da4-fc99-85f0-a96d05b9fca6@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).