From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1byHVT-0005LU-66
	for qemu-devel@nongnu.org; Sun, 23 Oct 2016 08:04:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1byHVO-00013X-Ph
	for qemu-devel@nongnu.org; Sun, 23 Oct 2016 08:04:03 -0400
Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38141)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>)
	id 1byHVO-00013P-Io
	for qemu-devel@nongnu.org; Sun, 23 Oct 2016 08:03:58 -0400
Received: by mail-wm0-x236.google.com with SMTP id c78so65714841wme.1
	for <qemu-devel@nongnu.org>; Sun, 23 Oct 2016 05:03:58 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <20161022095318.17775-1-marcandre.lureau@redhat.com>
	<20161022095318.17775-10-marcandre.lureau@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <9808a009-5716-6ea9-daba-68f0a6164cd6@redhat.com>
Date: Sun, 23 Oct 2016 14:03:55 +0200
MIME-Version: 1.0
In-Reply-To: <20161022095318.17775-10-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 09/38] char: introduce CharBackend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org



On 22/10/2016 11:52, Marc-André Lureau wrote:
> +    assert(be);

I feel a GNOME perturbation in the force. :D

The assertion (unlike g_return_value_if_fail) is unnecessary, because
you'd crash anyway eventually.

Paolo

> +    return be->chr;
> +}
> +
> +bool qemu_chr_fe_init(CharBackend *b, CharDriverState *s, Error **errp)
> +{
> +    int tag = 0;
> +
> +    assert(b);
> +    assert(s);
> +