From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OBPWN-000372-Bs
	for qemu-devel@nongnu.org; Mon, 10 May 2010 05:43:31 -0400
Received: from [140.186.70.92] (port=45074 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBPW5-00031J-V8
	for qemu-devel@nongnu.org; Mon, 10 May 2010 05:43:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OBODy-0004Ha-1P
	for qemu-devel@nongnu.org; Mon, 10 May 2010 04:25:01 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:51481
	helo=mx01.colomx.prod.int.phx2.redhat.com)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OBODu-0004FG-AK
	for qemu-devel@nongnu.org; Mon, 10 May 2010 04:20:22 -0400
Date: Mon, 10 May 2010 04:20:14 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <981188006.443991273479614098.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
In-Reply-To: <4BE5793F.9020603@mail.berlios.de>
Subject: Re: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning
	(WIN32_LEAN_AND_MEAN redefined)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

> 3. Change the definition of WIN32_LEAN_AND_MEAN in configure/make.
> 
> Solution 3 is a very simple change. It works for the moment,
> but would raise warnings when a library header file with a
> different definition of WIN32_LEAN_AND_MEAN is used.
> When I scanned the system headers of my mingw32
> installation, I saw these two variants:
> #define WIN32_LEAN_AND_MEAN
> #define WIN32_LEAN_AND_MEAN 1

Same here.

> So I still think my patch is the best solution.

I agree.  Let's report a bug to SDL as well.

Paolo