From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org
Subject: Re: [PATCH 2/4] build: make check-block a meson test
Date: Mon, 17 Jan 2022 18:48:49 +0100 [thread overview]
Message-ID: <98127462-394f-45ef-5c68-c8ad053f2ba7@redhat.com> (raw)
In-Reply-To: <7d7acd1b-5144-4ad5-102a-7517b43b1ac5@redhat.com>
On 1/17/22 11:09, Thomas Huth wrote:
>>
>> + qemu_iotests_formats = {
>> + 'raw': 'quick',
>> + 'qcow2': 'slow',
>> + 'qed': 'thorough',
>> + 'vmdk': 'thorough',
>> + 'vpc': 'thorough'
>> + }
>
> I think the default behavior for "quick" should be to test with qcow2 -
> most iotests require that format and that's what we're currently using
> with "make check-block" by default... i.e. please swap raw and qcow2 here.
You're right, also the tests should be disable on non-POSIX systems.
Paolo
next prev parent reply other threads:[~2022-01-17 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 22:21 [PATCH 0/4] make check-block a meson test Paolo Bonzini
2022-01-15 22:21 ` [PATCH 1/4] scripts/mtest2make: add support for SPEED=thorough Paolo Bonzini
2022-01-15 22:21 ` [PATCH 2/4] build: make check-block a meson test Paolo Bonzini
2022-01-17 10:09 ` Thomas Huth
2022-01-17 17:48 ` Paolo Bonzini [this message]
2022-01-15 22:21 ` [PATCH 3/4] qemu-iotests: require at least an argument to check-block.sh Paolo Bonzini
2022-01-15 22:21 ` [PATCH 4/4] check-block: replace -makecheck with TAP output Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2021-10-15 10:07 [RFC PATCH 0/4] Replace custom test harness with "meson test" Paolo Bonzini
2021-10-15 10:07 ` [PATCH 2/4] build: make check-block a meson test Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98127462-394f-45ef-5c68-c8ad053f2ba7@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).