From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9v4Q-0002Gs-VF for qemu-devel@nongnu.org; Mon, 06 Jun 2016 09:59:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9v4N-0005Oj-1w for qemu-devel@nongnu.org; Mon, 06 Jun 2016 09:59:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9v4M-0005Oa-SN for qemu-devel@nongnu.org; Mon, 06 Jun 2016 09:59:54 -0400 References: <1465214526-16096-1-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <983d24d4-247d-9643-3fb6-37f9da542744@redhat.com> Date: Mon, 6 Jun 2016 15:59:48 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] os-posix: include sys/mman.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 06/06/2016 14:11, Peter Maydell wrote: > On 6 June 2016 at 13:02, Paolo Bonzini wrote: >> qemu/osdep.h checks whether MAP_ANONYMOUS is defined, but this >> check is bogus without a previous include of sys/mman.h. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/sysemu/os-posix.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h >> index 07e3e5a..9c7dfdf 100644 >> --- a/include/sysemu/os-posix.h >> +++ b/include/sysemu/os-posix.h >> @@ -26,6 +26,7 @@ >> #ifndef QEMU_OS_POSIX_H >> #define QEMU_OS_POSIX_H >> >> +#include >> #include >> #include >> #include >> -- >> 2.5.5 > > Did you discover this because something broke, or just through > code inspection? sparse complained, but I don't think anything else breaks. > Reviewed-by: Peter Maydell > > We could add mman.h to clean-includes and zap the other includes > of it I guess. Yup, good idea. Thanks, Paolo